Subject: Re: linux-next: build warning in Linus'tree

From: Andrew Morton <[email-masked]>
Date: Tue, 25 May 2010 23:41:16 -0700

On Wed, 26 May 2010 08:29:45 +0200 Joakim Tjernlund <[email-masked]> wrote:

> Stephen Rothwell <[email-masked]> wrote on 2010/05/26 06:09:00:
> >
> > Hi Andrew,
> >
> > On Tue, 25 May 2010 18:20:40 -0700 Andrew Morton <[email-masked]> wrote:
> > >
> > > hmpf.  Does this fix?
> >
> > No.
> >
> > The problem is that __LITTLE_ENDIAN is only defined in
> > linux/byteorder/little_endian.h which is only included by little endian
> > architectures ...
> 
> Ah, not sure how to fix this ATM. Perhaps best to revert
>    crc32: use __BYTE_ORDER macro for endian detection
> for now.

yup.

> I suspect fixing this entails moving all endian tests to #if __BYTE_ORDER ...
> and then always define both __LITTLE_ENDIAN and __BIG_ENDIAN

Yes we can't define __LITTLE_ENDIAN to anything on big-endian without
breaking lots of other things.