Subject: Re: linux-next: build warning in Linus'tree

From: Stephen Rothwell <[email-masked]>
Date: Wed, 26 May 2010 17:14:24 +1000

Hi Andrew, Joakim,

On Tue, 25 May 2010 23:41:16 -0700 Andrew Morton <[email-masked]> wrote:
>
> On Wed, 26 May 2010 08:29:45 +0200 Joakim Tjernlund <[email-masked]> wrote:
> 
> > Stephen Rothwell <[email-masked]> wrote on 2010/05/26 06:09:00:
> > >
> > > On Tue, 25 May 2010 18:20:40 -0700 Andrew Morton <[email-masked]> wrote:
> > > >
> > > > hmpf.  Does this fix?
> > >
> > > No.
> > >
> > > The problem is that __LITTLE_ENDIAN is only defined in
> > > linux/byteorder/little_endian.h which is only included by little endian
> > > architectures ...
> > 
> > Ah, not sure how to fix this ATM. Perhaps best to revert
> >    crc32: use __BYTE_ORDER macro for endian detection
> > for now.
> 
> yup.

We also need to revert b3b77c8caef1750ebeea1054e39e358550ea9f55 ("endian:
#define __BYTE_ORDER") in order to get rid of the other warning I pointed out:

In file included from fs/jfs/jfs_types.h:33,
                 from fs/jfs/jfs_incore.h:26,
                 from fs/jfs/file.c:22:
fs/jfs/endian24.h:36:101: warning: "__LITTLE_ENDIAN" is not defined

I get this warning on powerpc builds for most of the files in fs/jfs ...
-- 
Cheers,
Stephen Rothwell                    [email-masked]
http://www.canb.auug.org.au/~sfr/