From: Randy Dunlap <randy.dunlap@oracle•com>
To: Anirban Chakraborty <anirban.chakraborty@qlogic•com>
Cc: linux-next@vger•kernel.org, netdev <netdev@vger•kernel.org>,
Ameen Rahman <ameen.rahman@qlogic•com>,
Amit Salecha <amit.salecha@qlogic•com>
Subject: Re: [PATCH net-next-2.6] qlcnic: Fix Compilation Issue when CONFIG_INET was not set
Date: Thu, 3 Jun 2010 11:20:06 -0700 [thread overview]
Message-ID: <20100603112006.0827a847.randy.dunlap@oracle.com> (raw)
In-Reply-To: <alpine.OSX.2.00.1006031034500.48386@macintosh-2.qlogic.org>
On Thu, 3 Jun 2010 10:50:56 -0700 Anirban Chakraborty wrote:
> Please apply.
>
> thanks,
> Anirban
>
> Original code was placed incorrectly inside a block of code marked
> with CONFIG_INET directive. Fix by moving it outside.
>
> Signed-off-by: Anirban Chakraborty <anirban.chakraborty@qlogic•com>
Reported-by: Randy Dunlap <randy.dunlap@oracle•com>
Tested-by: Randy Dunlap <randy.dunlap@oracle•com>
Thanks for the patch.
> ---
> drivers/net/qlcnic/qlcnic_main.c | 81 +++++++++++++++++++-------------------
> 1 files changed, 40 insertions(+), 41 deletions(-)
>
> diff --git a/drivers/net/qlcnic/qlcnic_main.c b/drivers/net/qlcnic/qlcnic_main.c
> index 119bcae..99371bc 100644
> --- a/drivers/net/qlcnic/qlcnic_main.c
> +++ b/drivers/net/qlcnic/qlcnic_main.c
> @@ -2581,6 +2581,46 @@ reschedule:
> qlcnic_schedule_work(adapter, qlcnic_fw_poll_work, FW_POLL_DELAY);
> }
>
> +static int
> +qlcnicvf_start_firmware(struct qlcnic_adapter *adapter)
> +{
> + int err;
> +
> + err = qlcnic_can_start_firmware(adapter);
> + if (err)
> + return err;
> +
> + qlcnic_check_options(adapter);
> +
> + adapter->need_fw_reset = 0;
> +
> + return err;
> +}
> +
> +static int
> +qlcnicvf_config_bridged_mode(struct qlcnic_adapter *adapter, u32 enable)
> +{
> + return -EOPNOTSUPP;
> +}
> +
> +static int
> +qlcnicvf_config_led(struct qlcnic_adapter *adapter, u32 state, u32 rate)
> +{
> + return -EOPNOTSUPP;
> +}
> +
> +static int
> +qlcnicvf_set_ilb_mode(struct qlcnic_adapter *adapter)
> +{
> + return -EOPNOTSUPP;
> +}
> +
> +static void
> +qlcnicvf_clear_ilb_mode(struct qlcnic_adapter *adapter)
> +{
> + return;
> +}
> +
> static ssize_t
> qlcnic_store_bridged_mode(struct device *dev,
> struct device_attribute *attr, const char *buf, size_t len)
> @@ -2954,47 +2994,6 @@ done:
> return NOTIFY_DONE;
> }
>
> -static int
> -qlcnicvf_start_firmware(struct qlcnic_adapter *adapter)
> -{
> - int err;
> -
> - err = qlcnic_can_start_firmware(adapter);
> - if (err)
> - return err;
> -
> - qlcnic_check_options(adapter);
> -
> - adapter->need_fw_reset = 0;
> -
> - return err;
> -}
> -
> -static int
> -qlcnicvf_config_bridged_mode(struct qlcnic_adapter *adapter, u32 enable)
> -{
> - return -EOPNOTSUPP;
> -}
> -
> -static int
> -qlcnicvf_config_led(struct qlcnic_adapter *adapter, u32 state, u32 rate)
> -{
> - return -EOPNOTSUPP;
> -}
> -
> -static int
> -qlcnicvf_set_ilb_mode(struct qlcnic_adapter *adapter)
> -{
> - return -EOPNOTSUPP;
> -}
> -
> -static void
> -qlcnicvf_clear_ilb_mode(struct qlcnic_adapter *adapter)
> -{
> - return;
> -}
> -
> -
> static struct notifier_block qlcnic_netdev_cb = {
> .notifier_call = qlcnic_netdev_event,
> };
> --
> 1.6.0.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-06-03 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 17:50 [PATCH net-next-2.6] qlcnic: Fix Compilation Issue when CONFIG_INET was not set Anirban Chakraborty
2010-06-03 18:20 ` Randy Dunlap [this message]
2010-06-04 3:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100603112006.0827a847.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=ameen.rahman@qlogic$(echo .)com \
--cc=amit.salecha@qlogic$(echo .)com \
--cc=anirban.chakraborty@qlogic$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox