From: Martin Schwidefsky <schwidefsky@de•ibm.com>
To: Tejun Heo <tj@kernel•org>
Cc: Sachin Sant <sachinp@in•ibm.com>,
linux-s390@vger•kernel.org,
linux-kernel <linux-kernel@vger•kernel.org>,
"linux-next@vger•kernel.org" <linux-next@vger•kernel.org>
Subject: Re: [-next July 21] s390 build failure : kernel/workqueue.o
Date: Thu, 22 Jul 2010 11:25:57 +0200 [thread overview]
Message-ID: <20100722112557.14b65077@mschwide.boeblingen.de.ibm.com> (raw)
In-Reply-To: <4C4718D5.1080902@kernel.org>
On Wed, 21 Jul 2010 17:57:09 +0200
Tejun Heo <tj@kernel•org> wrote:
> Hello,
>
> On 07/21/2010 12:40 PM, Sachin Sant wrote:
> > Today's next fails to build on a s390 box with
> >
> > CC kernel/workqueue.o
> > kernel/workqueue.c: In function 'init_workqueues':
> > kernel/workqueue.c:3525: error: negative width in bit-field '<anonymous>'
> > make[1]: *** [kernel/workqueue.o] Error 1
> >
> > Yesterday's next was good.
> > The following patches added/changed the BUILD_BUG_ON() statement.
> >
> > bdbc5dd7de5d07d6c9d3536e598956165a031d4c
> > workqueue: prepare for WQ_UNBOUND implementation
> > 7a22ad757ec75186ad43a5b4670fa7423ee8f480
> > workqueue: carry cpu number in work data once execution starts
> >
> > I have gcc version 4.3.2 installed on the system.
>
> Hmmm... that's surprising. Can you please attach the .config?
The BUILD_BUG_ON line gets expanded to:
((void)(sizeof(struct { int:-!!(WORK_CPU_LAST << WORK_STRUCT_FLAG_BITS >= 0x0UL); })));
WORK_CPU_LAST is:
enum {
..
WORK_CPU_NONE = 32 + 1,
WORK_CPU_LAST = WORK_CPU_NONE,
..
};
WORK_STRUCT_FLAG_BITS is:
WORK_STRUCT_COLOR_SHIFT = 2,
WORK_STRUCT_COLOR_BITS = 4,
WORK_STRUCT_FLAG_BITS = WORK_STRUCT_COLOR_SHIFT +
WORK_STRUCT_COLOR_BITS,
which boils it down to
((void)(sizeof(struct { int:-!!(33 << 6 >= 0x0UL); })));
gcc doesn't like this construct.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2010-07-22 9:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 10:40 [-next July 21] s390 build failure : kernel/workqueue.o Sachin Sant
2010-07-21 15:57 ` Tejun Heo
2010-07-22 5:49 ` Sachin Sant
2010-07-22 9:25 ` Martin Schwidefsky [this message]
2010-07-22 12:25 ` [PATCH wq#for-next] workqueue: fix how cpu number is stored in work->data Tejun Heo
2010-07-22 15:10 ` Martin Schwidefsky
2010-07-22 20:41 ` Tejun Heo
2010-07-22 20:13 ` Michal Simek
2010-07-22 7:19 ` [-next July 21] s390 build failure : kernel/workqueue.o Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100722112557.14b65077@mschwide.boeblingen.de.ibm.com \
--to=schwidefsky@de$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=sachinp@in$(echo .)ibm.com \
--cc=tj@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox