Subject: Re: [PATCH -next] staging/line6: needs to select SND_PCM

From: Greg KH <[email-masked]>
Date: Wed, 28 Jul 2010 08:19:08 -0700

On Wed, Jul 28, 2010 at 03:59:50PM +0200, Takashi Iwai wrote:
> At Tue, 27 Jul 2010 12:21:19 -0700,
> Randy Dunlap wrote:
> > 
> > From: Randy Dunlap <[email-masked]>
> > 
> > line6 uses snd_pcm*() functions, so it should select SND_PCM.
> > 
> > ERROR: "snd_pcm_period_elapsed" [drivers/staging/line6/line6usb.ko] undefined!
> > ERROR: "snd_pcm_set_ops" [drivers/staging/line6/line6usb.ko] undefined!
> > ERROR: "snd_pcm_lib_free_pages" [drivers/staging/line6/line6usb.ko] undefined!
> > ERROR: "snd_pcm_lib_ioctl" [drivers/staging/line6/line6usb.ko] undefined!
> > ERROR: "snd_pcm_lib_malloc_pages" [drivers/staging/line6/line6usb.ko] undefined!
> > ERROR: "snd_pcm_hw_constraint_ratdens" [drivers/staging/line6/line6usb.ko] undefined!
> > ERROR: "snd_pcm_format_physical_width" [drivers/staging/line6/line6usb.ko] undefined!
> > ERROR: "snd_pcm_lib_preallocate_pages_for_all" [drivers/staging/line6/line6usb.ko] undefined!
> > ERROR: "snd_pcm_new" [drivers/staging/line6/line6usb.ko] undefined!
> > 
> > Signed-off-by: Randy Dunlap <[email-masked]>
> > Cc: Markus Grabner <[email-masked]>
> > ---
> >  drivers/staging/line6/Kconfig |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > Third patch to staging/line6/Kconfig.  :(
> > Developers should know what kernel services their code needs
> > and how to configure for those needs.
> 
> I think this should be applied rather to 2.6.35 tree.

I'll queue this up for stable to get it into the .35 tree eventually :)

thanks,

greg k-h