public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>, davem@davemloft•net
Cc: linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
	netdev <netdev@vger•kernel.org>
Subject: [PATCH -next] net: ks8842 depends on DMA_ENGINE
Date: Thu, 29 Jul 2010 10:14:27 -0700	[thread overview]
Message-ID: <20100729101427.2aafd6e7.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20100729143211.9e7edaed.sfr@canb.auug.org.au>

From: Randy Dunlap <randy.dunlap@oracle•com>

ks8842 uses dma channel functions, so it should depend on DMA_ENGINE.

ERROR: "__dma_request_channel" [drivers/net/ks8842.ko] undefined!
ERROR: "dma_release_channel" [drivers/net/ks8842.ko] undefined!

Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
---
 drivers/net/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20100729.orig/drivers/net/Kconfig
+++ linux-next-20100729/drivers/net/Kconfig
@@ -1751,7 +1751,7 @@ config TLAN
 
 config KS8842
 	tristate "Micrel KSZ8841/42 with generic bus interface"
-	depends on HAS_IOMEM
+	depends on HAS_IOMEM && DMA_ENGINE
 	help
 	 This platform driver is for KSZ8841(1-port) / KS8842(2-port)
 	 ethernet switch chip (managed, VLAN, QoS) from Micrel or

  parent reply	other threads:[~2010-07-29 17:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-29  4:32 linux-next: Tree for July 29 Stephen Rothwell
2010-07-29 17:13 ` [PATCH -next] mtd: redwood depends on MTD_PARTITIONS Randy Dunlap
2010-07-29 17:14 ` Randy Dunlap [this message]
2010-07-31  5:10   ` [PATCH -next] net: ks8842 depends on DMA_ENGINE David Miller
2010-07-29 17:16 ` [PATCH -next] scsi: be2iscsi needs ISCSI_BOOT_SYSFS Randy Dunlap
2010-07-29 19:34   ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100729101427.2aafd6e7.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox