Subject: Re: remove inode_setattr

From: Andrew Morton <[email-masked]>
Date: Tue, 10 Aug 2010 17:59:44 -0700

On Wed, 11 Aug 2010 01:52:16 +0100
Al Viro <[email-masked]> wrote:

> Whiskey Tango Fotrot, Over
> 
> In Linus' tree we have
> commit 1025774ce411f2bd4b059ad7b53f0003569b74fa
> Author: Christoph Hellwig <[email-masked]>
> Date:   Fri Jun 4 11:30:02 2010 +0200
> ...
> diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
> index 4331b3b..4b3ad6a 100644
> --- a/fs/9p/vfs_inode.c
> +++ b/fs/9p/vfs_inode.c
> @@ -896,10 +896,19 @@ static int v9fs_vfs_setattr(struct dentry *dentry, struct 
>         }
>  
>         retval = p9_client_wstat(fid, &wstat);
> -       if (retval >= 0)
> -               retval = inode_setattr(dentry->d_inode, iattr);
> +       if (retval < 0)
> +               return retval;
> +
> +       if ((iattr->ia_valid & ATTR_SIZE) &&
> +           iattr->ia_size != i_size_read(dentry->d_inode)) {
> +               retval = vmtruncate(dentry->d_inode, iattr->ia_size);
> +               if (retval)
> +                       return retval;
> +       }
> 
> So what the hell is going on?

That's v9fs_vfs_setattr().  The problem is in the new
v9fs_vfs_setattr_dotl().