Subject: Re: [PATCH -next] mfd: tps6586x depends on GPIOLIB

From: Samuel Ortiz <[email-masked]>
Date: Wed, 11 Aug 2010 01:14:22 +0200

On Tue, Aug 10, 2010 at 09:40:59AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <[email-masked]>
> 
> tps6586x uses gpio interfaces, so it should depend on GPIOLIB.
Thanks Randy, I merged this one into the yet to be pulled tps6586x driver.

Cheers,
Samuel.

> Fixes these build errors:
> 
> drivers/mfd/tps6586x.c:41: error: field 'gpio' has incomplete type
> drivers/mfd/tps6586x.c:195: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/mfd/tps6586x.c:195: warning: initialization from incompatible pointer type
> drivers/mfd/tps6586x.c:210: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/mfd/tps6586x.c:210: warning: initialization from incompatible pointer type
> drivers/mfd/tps6586x.c:219: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/mfd/tps6586x.c:219: warning: initialization from incompatible pointer type
> drivers/mfd/tps6586x.c:249: error: implicit declaration of function 'gpiochip_add'
> 
> Signed-off-by: Randy Dunlap <[email-masked]>
> Cc: Samuel Ortiz <[email-masked]>
> ---
>  drivers/mfd/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20100810.orig/drivers/mfd/Kconfig
> +++ linux-next-20100810/drivers/mfd/Kconfig
> @@ -543,7 +543,7 @@ config MFD_JZ4740_ADC
>  
>  config MFD_TPS6586X
>  	tristate "TPS6586x Power Management chips"
> -	depends on I2C
> +	depends on I2C && GPIOLIB
>  	select MFD_CORE
>  	help
>  	  If you say yes here you get support for the TPS6586X series of

-- 
Intel Open Source Technology Centre
http://oss.intel.com/