From: Dmitry Torokhov <dmitry.torokhov@gmail•com>
To: Sachin Sant <sachinp@in•ibm.com>
Cc: schwidefsky@de•ibm.com, linux-s390@vger•kernel.org,
heiko.carstens@de•ibm.com, linux-kernel@vger•kernel.org,
linux-next@vger•kernel.org
Subject: Re: [-next PATCH] Fix s390 keyboard driver build break
Date: Sat, 21 Aug 2010 00:40:19 -0700 [thread overview]
Message-ID: <20100821074018.GB2160@core.coreip.homeip.net> (raw)
In-Reply-To: <20100821072126.8965.41003.sendpatchset@localhost.localdomain>
Hi Sachin,
On Sat, Aug 21, 2010 at 12:51:26PM +0530, Sachin Sant wrote:
> Next 20100820 fails to build on s390 with
>
> drivers/s390/char/keyboard.c: In function 'kbd_keycode':
> drivers/s390/char/keyboard.c:308: error: too many arguments to function 'handle_sysrq'
> make[2]: *** [drivers/s390/char/keyboard.o] Error 1
>
> The following commit changed handle_sysrq() function to accept single argument.
>
> commit a821bafce37b26499e2bfbf2e6b96b0636efc014
> Input: sysrq - drop tty argument form handle_sysrq()
>
> Adapt the code accordingly to fix the build break.
>
> Signed-off-by: Sachin Sant <sachinp@in•ibm.com>
> ---
>
> diff -Naurp next20100820/drivers/s390/char/keyboard.c next20100820-new//drivers/s390/char/keyboard.c
> --- next20100820/drivers/s390/char/keyboard.c 2010-08-16 06:11:37.000000000 +0530
> +++ next20100820-new//drivers/s390/char/keyboard.c 2010-08-21 11:55:25.000000000 +0530
> @@ -305,7 +305,7 @@ kbd_keycode(struct kbd_data *kbd, unsign
> if (kbd->sysrq) {
> if (kbd->sysrq == K(KT_LATIN, '-')) {
> kbd->sysrq = 0;
> - handle_sysrq(value, kbd->tty);
> + handle_sysrq(value);
> return;
> }
> if (value == '-') {
Thank you very much for the patch. I folded it into original patch to
avoid build failures in case someone needs to bisect.
--
Dmitry
prev parent reply other threads:[~2010-08-21 7:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-21 7:21 [-next PATCH] Fix s390 keyboard driver build break Sachin Sant
2010-08-21 7:40 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100821074018.GB2160@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail$(echo .)com \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=sachinp@in$(echo .)ibm.com \
--cc=schwidefsky@de$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox