From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Yinghai Lu <yinghai@kernel•org>
Cc: Ingo Molnar <mingo@elte•hu>, Thomas Gleixner <tglx@linutronix•de>,
"H. Peter Anvin" <hpa@zytor•com>,
Peter Zijlstra <peterz@infradead•org>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
ppc-dev <linuxppc-dev@lists•ozlabs.org>
Subject: Re: linux-next: build warnings after merge of the final tree (tip treee related)
Date: Wed, 15 Sep 2010 14:39:04 +1000 [thread overview]
Message-ID: <20100915143904.ca226c83.sfr@canb.auug.org.au> (raw)
In-Reply-To: <4C90226E.4050306@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
Hi Yinghai,
On Tue, 14 Sep 2010 18:33:34 -0700 Yinghai Lu <yinghai@kernel•org> wrote:
>
> On 09/14/2010 05:29 PM, Stephen Rothwell wrote:
> >
> > Do not remove the "extern" key word.
>
> why? you got another warning?
It is normal C coding practice to mark declarations in header files with
extern. It probably doesn't strictly matter for functions, but I have
seen a case where not doing so to a variable lead to multiple definitions
of the variable. Consistency is also good.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2010-09-15 4:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 3:27 linux-next: build warnings after merge of the final tree (tip treee related) Stephen Rothwell
2010-09-13 4:14 ` Yinghai Lu
2010-09-13 4:39 ` Stephen Rothwell
2010-09-13 8:24 ` Yinghai Lu
2010-09-14 4:50 ` Stephen Rothwell
2010-09-14 23:00 ` Yinghai Lu
2010-09-15 0:29 ` Stephen Rothwell
2010-09-15 1:33 ` Yinghai Lu
2010-09-15 4:39 ` Stephen Rothwell [this message]
2010-09-15 5:00 ` Stephen Rothwell
2010-09-15 9:25 ` Ingo Molnar
2010-09-15 20:05 ` [PATCH -v4] memblock: Fix section mismatch warnings Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100915143904.ca226c83.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=benh@kernel$(echo .)crashing.org \
--cc=hpa@zytor$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@elte$(echo .)hu \
--cc=peterz@infradead$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=yinghai@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox