From: Greg KH <greg@kroah•com>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
gregkh@suse•de, Al Cho <acho@novell•com>,
driverdevel <devel@driverdev•osuosl.org>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH -next] staging/keucr: update TODO list and ask question about it
Date: Thu, 16 Sep 2010 12:28:31 -0700 [thread overview]
Message-ID: <20100916192831.GB10397@kroah.com> (raw)
In-Reply-To: <20100914154148.826a0334.randy.dunlap@oracle.com>
On Tue, Sep 14, 2010 at 03:41:48PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle•com>
>
> Update keucr TODO with additional work items.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
> Cc: Al Cho <acho@novell•com>
> ---
> drivers/staging/keucr/TODO | 3 +++
> 1 file changed, 3 insertions(+)
>
> and I don't understand this TODO comment:
> " - determine if the driver should not be using a duplicate
> version of the usb-storage scsi interface code, but should
> be merged into the drivers/usb/storage/ directory and
> infrastructure instead."
>
> Of course the driver should not use a duplicate of the usb-storage
> SCSI interface code. Did someone seriously think that it should?
Well, it's not the whole copy, and we are still trying to unwind the
hooks here. It might be that this is just another scsi driver, one that
happens to also be a USB device, as I don't think this device follows
the usb-storage spec at all.
So it's still an unanswered question.
thanks,
greg k-h
prev parent reply other threads:[~2010-09-16 19:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 3:43 linux-next: Tree for September 13 Stephen Rothwell
2010-09-14 22:39 ` [PATCH -next] staging/bcm: fix build for CONFIG_PM not enabled Randy Dunlap
2010-09-14 22:39 ` [PATCH -next] staging/bcm: fix printk format warnings Randy Dunlap
2010-09-14 22:41 ` [PATCH -next] staging/keucr: fix build when CONFIG_PM is not enabled Randy Dunlap
2010-09-14 22:41 ` [PATCH -next] staging/keucr: update TODO list and ask question about it Randy Dunlap
2010-09-16 19:28 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916192831.GB10397@kroah.com \
--to=greg@kroah$(echo .)com \
--cc=acho@novell$(echo .)com \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=gregkh@suse$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox