From: Randy Dunlap <rdunlap@xenotime•net>
To: Greg KH <gregkh@suse•de>
Cc: Greg KH <greg@kroah•com>, Stephen Rothwell <sfr@canb•auug.org.au>,
Kay Sievers <kay.sievers@vrfy•org>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH -next] driver core: fix build for CONFIG_BLOCK=n
Date: Thu, 23 Sep 2010 13:34:54 -0700 [thread overview]
Message-ID: <20100923133454.786049c2.rdunlap@xenotime.net> (raw)
In-Reply-To: <20100923203006.GB10687@suse.de>
On Thu, 23 Sep 2010 13:30:06 -0700 Greg KH wrote:
> On Thu, Sep 23, 2010 at 12:47:51PM -0700, Randy Dunlap wrote:
> > On Thu, 23 Sep 2010 12:16:29 -0700 Greg KH wrote:
> >
> > > On Thu, Sep 23, 2010 at 11:15:41AM -0700, Randy Dunlap wrote:
> > > > On Tue, 21 Sep 2010 15:31:15 -0700 Greg KH wrote:
> > > >
> > > > > On Mon, Sep 20, 2010 at 09:20:34AM -0700, Randy Dunlap wrote:
> > > > > > From: Randy Dunlap <randy.dunlap@oracle•com>
> > > > > >
> > > > > > Fix build when CONFIG_BLOCK is not enabled (since SEP-06).
> > > > > > Fixes these build errors:
> > > > > >
> > > > > > drivers/base/core.c: In function 'get_device_parent':
> > > > > > drivers/base/core.c:622: error: 'block_class' undeclared (first use in this function)
> > > > > > drivers/base/core.c: In function 'device_add_class_symlinks':
> > > > > > drivers/base/core.c:712: error: 'block_class' undeclared (first use in this function)
> > > > > > drivers/base/core.c: In function 'device_remove_class_symlinks':
> > > > > > drivers/base/core.c:742: error: 'block_class' undeclared (first use in this function)
> > > > > >
> > > > > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
> > > > >
> > > > > This should no longer be needed with the next linux-next tree as the
> > > > > logic in this area has changed thanks to Andi's patch.
> > ~~~~~~~~~~~~~~~~~~~~~~~
> >
> > > >
> > > > {sorry about resend, email problems}
> > > >
> > > >
> > > > Still seeing this build error. (linux-next 2010-0923)
> > > > Will you be merging some patch soon?
> > >
> > > Not unless someone provides it. I know of no valid user of the kernel
> > > that does not enable CONFIG_BLOCK, so I really doubt this will ever hit
> > > anyone in "real life" so it's _way_ down the list of things I have to do
> > > at the moment, sorry.
Maybe you should just submit a patch to remove CONFIG_BLOCK.
(and many other kconfig symbols)
> > so what was your comment about Andi's patch (above)?
>
> It's merged already, and because of it, your patch failed to apply.
OK, so I disagree with your comment:
> > > > > This should no longer be needed with the next linux-next tree as the
> > > > > logic in this area has changed thanks to Andi's patch.
but I now understand that my patch failed to apply. Thanks for the info.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
prev parent reply other threads:[~2010-09-23 20:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 6:12 linux-next: Tree for September 20 Stephen Rothwell
2010-09-20 16:18 ` linux-next: Tree for September 20 (scsi/pcmcia/nsp_cs.c) Randy Dunlap
2010-09-20 17:42 ` Dominik Brodowski
2010-09-20 16:20 ` [PATCH -next] driver core: fix build for CONFIG_BLOCK=n Randy Dunlap
2010-09-21 22:31 ` Greg KH
2010-09-23 17:57 ` Randy Dunlap
2010-09-23 18:15 ` Randy Dunlap
2010-09-23 19:16 ` Greg KH
2010-09-23 19:47 ` Randy Dunlap
2010-09-23 20:30 ` Greg KH
2010-09-23 20:34 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100923133454.786049c2.rdunlap@xenotime.net \
--to=rdunlap@xenotime$(echo .)net \
--cc=greg@kroah$(echo .)com \
--cc=gregkh@suse$(echo .)de \
--cc=kay.sievers@vrfy$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox