From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Mauro Carvalho Chehab <mchehab@infradead•org>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Palash Bandyopadhyay <palash.bandyopadhyay@conexant•com>,
Devin Heitmueller <dheitmueller@hauppauge•com>,
Arnd Bergmann <arnd@arndb•de>
Subject: linux-next: build failure after merge of the final tree (v4l-dvb tree related)
Date: Tue, 19 Oct 2010 18:07:30 +1100 [thread overview]
Message-ID: <20101019180730.5beac8af.sfr@canb.auug.org.au> (raw)
Hi Mauro,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/media/video/cx231xx/cx231xx-417.c: In function 'cx231xx_load_firmware':
drivers/media/video/cx231xx/cx231xx-417.c:943: error: implicit declaration of function 'vmalloc'
drivers/media/video/cx231xx/cx231xx-417.c:943: warning: cast to pointer from integer of different size
drivers/media/video/cx231xx/cx231xx-417.c:950: warning: cast to pointer from integer of different size
drivers/media/video/cx231xx/cx231xx-417.c:1039: error: implicit declaration of function 'vfree'
Caused by commit e0bb3704be9decb10985b0886031e76a228b5f32 ("[media]
cx231xx: Added support for Carraera, Shelby, RDx_253S and VIDEO_GRABBER").
Also, I don't think Arnd is going to like the new BKL usage also
introduced by the commit. ;-)
I added the following patch for today:
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Tue, 19 Oct 2010 18:01:25 +1100
Subject: [PATCH] v4l-dvb: using vmalloc needs vmalloc.h in cx231xx-417.c
Fixes these build errors and warnings:
drivers/media/video/cx231xx/cx231xx-417.c: In function 'cx231xx_load_firmware':
drivers/media/video/cx231xx/cx231xx-417.c:943: error: implicit declaration of function 'vmalloc'
drivers/media/video/cx231xx/cx231xx-417.c:943: warning: cast to pointer from integer of different size
drivers/media/video/cx231xx/cx231xx-417.c:950: warning: cast to pointer from integer of different size
drivers/media/video/cx231xx/cx231xx-417.c:1039: error: implicit declaration of function 'vfree'
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
drivers/media/video/cx231xx/cx231xx-417.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/cx231xx/cx231xx-417.c b/drivers/media/video/cx231xx/cx231xx-417.c
index e456b97..aab21f3 100644
--- a/drivers/media/video/cx231xx/cx231xx-417.c
+++ b/drivers/media/video/cx231xx/cx231xx-417.c
@@ -32,6 +32,7 @@
#include <linux/device.h>
#include <linux/firmware.h>
#include <linux/smp_lock.h>
+#include <linux/vmalloc.h>
#include <media/v4l2-common.h>
#include <media/v4l2-ioctl.h>
#include <media/cx2341x.h>
--
1.7.1
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
next reply other threads:[~2010-10-19 7:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 7:07 Stephen Rothwell [this message]
2010-10-21 10:53 ` linux-next: build failure after merge of the final tree (v4l-dvb tree related) Mauro Carvalho Chehab
-- strict thread matches above, loose matches on Subject: below --
2010-11-23 2:38 Stephen Rothwell
2010-12-07 3:18 ` Stephen Rothwell
2013-03-26 6:18 Stephen Rothwell
2013-03-26 12:04 ` Mauro Carvalho Chehab
2013-03-26 23:52 ` Stephen Rothwell
2013-03-27 11:11 ` Stephen Rothwell
2013-07-08 5:26 Stephen Rothwell
2013-07-08 12:58 ` Mauro Carvalho Chehab
2013-07-09 7:03 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019180730.5beac8af.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=arnd@arndb$(echo .)de \
--cc=dheitmueller@hauppauge$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mchehab@infradead$(echo .)org \
--cc=palash.bandyopadhyay@conexant$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox