From: Andrew Morton <akpm@linux-foundation•org>
To: michael.hennerich@analog•com
Cc: linux-kernel@vger•kernel.org,
device-drivers-devel@blackfin•uclinux.org, drivers@analog•com,
rpurdie@linux•intel.com, linux-next@vger•kernel.org,
sfr@canb•auug.org.au
Subject: Re: [PATCH] video: backlight: adp8870: Fix warn_unused_result warning reported by Stephen Rothwell
Date: Fri, 29 Oct 2010 12:25:34 -0700 [thread overview]
Message-ID: <20101029122534.d4d6a439.akpm@linux-foundation.org> (raw)
In-Reply-To: <1288364066-18709-1-git-send-email-michael.hennerich@analog.com>
I have some bones to gnaw. Not specific to this patch ;)
On Fri, 29 Oct 2010 16:54:26 +0200
<michael.hennerich@analog•com> wrote:
> Subject: [PATCH] video: backlight: adp8870: Fix warn_unused_result warning reported by Stephen Rothwell
Lots of people are doing this "video: backlight: adp8870:" thing
lately. And it's good, but why not just use
"drivers/video/backlight/adp8860_bl.c" to identify the affected
susbsytem/file/etc? It's simple and uniform. It's not always the
appropriate thing to do, but replacing the /'s with ": " seems rather
random and pointless.
Secondly, no, the point of this patch is not to fix a
warn_unused_result() warning! The patch actually fixes a bug: the code
wasn't checking the strict_strtoul() return value. The warning is
simply what alerted us to the bug.
So I renamed this patch to
drivers/video/backlight/adp8860_bl.c: check strict_strtoul() return value
next prev parent reply other threads:[~2010-10-29 19:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 14:54 [PATCH] video: backlight: adp8870: Fix warn_unused_result warning reported by Stephen Rothwell michael.hennerich
2010-10-29 19:25 ` Andrew Morton [this message]
2010-11-02 7:35 ` [Device-drivers-devel] " Mike Frysinger
2010-11-02 8:57 ` Hennerich, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101029122534.d4d6a439.akpm@linux-foundation.org \
--to=akpm@linux-foundation$(echo .)org \
--cc=device-drivers-devel@blackfin$(echo .)uclinux.org \
--cc=drivers@analog$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=michael.hennerich@analog$(echo .)com \
--cc=rpurdie@linux$(echo .)intel.com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox