Subject: Re: linux-next: Tree for November 17

From: Stephen Rothwell <[email-masked]>
Date: Thu, 18 Nov 2010 10:14:59 +1100

On Wed, 17 Nov 2010 09:59:20 -0800 Randy Dunlap <[email-masked]> wrote:
>
> Why was #include <linux/smp_lock.h> removed from <linux/hardirq.h> ?
> 
> I added #include <linux/smp_lock.h> to i387.h, but them mm/filemap.c build fails
> with the same error:
> 
> linux-next-20101117/mm/filemap.c: In function 'iov_iter_copy_from_user_atomic':
> linux-next-20101117/mm/filemap.c:1936: error: implicit declaration of function 'kernel_locked'

Was this fixed before Linus took that patch?  Also, the #include of
linux/smp_lock.h in linux/hardirq.h was the only line between #ifdef
CONFIG_PREEMPT and #endif ... was this patch even reviewed?

Maybe (after it was reviewed) it should have been given more time in
linux-next before being merged.

-- 
Cheers,
Stephen Rothwell                    [email-masked]
http://www.canb.auug.org.au/~sfr/