public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw•cz>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
	gregkh@suse•de, linux-next@vger•kernel.org,
	LKML <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH -next] staging: fix winbond build, needs delay.h
Date: Fri, 19 Nov 2010 18:37:32 +0100	[thread overview]
Message-ID: <20101119173731.GA25098@elf.ucw.cz> (raw)
In-Reply-To: <20101119093018.340dab03.randy.dunlap@oracle.com>

On Fri 2010-11-19 09:30:18, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle•com>
> 
> winbond drivers use msleep() and delay(), so include linux/delay.h
> in a common header file to prevent build errors.
> 
> drivers/staging/winbond/phy_calibration.c:987: error: implicit declaration of function 'msleep'
> drivers/staging/winbond/phy_calibration.c:1556: error: implicit declaration of function 'udelay'
> drivers/staging/winbond/reg.c:894: error: implicit declaration of function 'msleep'
> drivers/staging/winbond/reg.c:1178: error: implicit declaration of function 'udelay'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>

Ack.

> ---
>  drivers/staging/winbond/sysdef.h |    3 +++
>  1 file changed, 3 insertions(+)
> 
> --- linux-next-20101119.orig/drivers/staging/winbond/sysdef.h
> +++ linux-next-20101119/drivers/staging/winbond/sysdef.h
> @@ -2,6 +2,9 @@
>  
>  #ifndef SYS_DEF_H
>  #define SYS_DEF_H
> +
> +#include <linux/delay.h>
> +
>  #define WB_LINUX
>  #define WB_LINUX_WPA_PSK
>  

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2010-11-19 17:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-19  3:32 linux-next: Tree for November 19 Stephen Rothwell
2010-11-19 17:15 ` linux-next: Tree for November 19 (sched_fair) Randy Dunlap
2010-11-19 17:16 ` linux-next: Tree for November 19 (rtmutex) Randy Dunlap
2010-12-02 19:52   ` Randy Dunlap
2010-11-19 17:30 ` [PATCH -next] staging: fix winbond build, needs delay.h Randy Dunlap
2010-11-19 17:37   ` Pavel Machek [this message]
2010-11-19 17:38   ` Greg KH
2010-11-19 17:48     ` Randy Dunlap
2010-11-19 17:54       ` Greg KH
2010-11-19 17:40 ` linux-next: Tree for November 19 Zimny Lech
2010-11-19 17:42   ` Alan Cox
2010-11-19 18:35     ` Zimny Lech
2010-11-20  5:50 ` Zimny Lech
2010-11-20  5:52   ` Zimny Lech
2010-11-20 10:44     ` Jens Axboe
2010-11-20  7:15 ` Zimny Lech

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101119173731.GA25098@elf.ucw.cz \
    --to=pavel@ucw$(echo .)cz \
    --cc=gregkh@suse$(echo .)de \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=randy.dunlap@oracle$(echo .)com \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox