public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle•com>
To: Milton Miller <miltonm@bga•com>, linux-next@vger•kernel.org
Cc: Zimny Lech <napohybelskurwysynom2010@gmail•com>,
	Valdis Kletnieks <Valdis.Kletnieks@vt•edu>,
	Greg KH <gregkh@suse•de>,
	linux-kernel@vger•kernel.org
Subject: Re: The longest build error ever, ever, ever seen :) (Re:linux-next: Tree for November 26)
Date: Wed, 1 Dec 2010 10:30:35 -0800	[thread overview]
Message-ID: <20101201103035.0e0b22cf.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1290927314_21183@mail4.comsite.net>

On Sun, 28 Nov 2010 00:55:14 -0600 Milton Miller wrote:

[also adding linux-next back to cc: list]


> On Sat Nov 27 2010 around 13:13:03 EST, Valdis Kletnieks wrote:
> > On Sat, 27 Nov 2010 08:45:55 PST, Greg KH said:
> > > On Sat, Nov 27, 2010 at 09:56:45AM +0100, Zimny Lech wrote:
> > > > Ave!
> > > >
> > > > 2010/11/26 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>:
> > > > > Hi all,
> > > > >
> > > >
> > > > OMG, LOL, this one is awesome :) The longest build error ever, ever,
> > > > ever seen! Fscking awesome, someone gets Guiness World Record :)
> > > >
> > > > LD drivers/staging/built-in.o
> > > > drivers/staging/rtl8192e/built-in.o: In function `rtl8192_setBBreg':
> > > > (.text+0xae00): multiple definition of `rtl8192_setBBreg'
> > > > drivers/staging/rtl8192u/built-in.o:(.text+0xa1a0): first defined here
> > >
> > > You built both of these drivers into the kernel, which causes the
> > > problem. Try building them as modules, or just one as a module, and
> > > that will solve the problem.
> > 
> > We probably should create some Kconfig magic to prevent this situation?
> > 
> > depends (othermodule != 'y') || (myself != 'y')
> > 
> > or am I on the wrong track here?
> > 
> 
> A simple
> 
> depends on !OTHERMODULE
> 
> allows either to be built-in or both to be modular.
> 
> It also documents what conflicts.
> 
> (see Menu dependencies in Documentation/kbuild/kconfig-language.txt)

When added for 2 drivers that should not both be built-in, that
causes this error message:

drivers/staging/rtl8192u/Kconfig:1:error: recursive dependency detected!
drivers/staging/rtl8192u/Kconfig:1:     symbol RTL8192U depends on RTL8192E
drivers/staging/rtl8192e/Kconfig:1:     symbol RTL8192E depends on RTL8192U

but yes, only one driver is then built-in.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  parent reply	other threads:[~2010-12-01 18:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-27  8:56 The longest build error ever, ever, ever seen :) (Re: linux-next: Tree for November 26) Zimny Lech
2010-11-27 16:45 ` Greg KH
2010-11-27 18:12   ` Valdis.Kletnieks
2010-11-27 18:27     ` Greg KH
2010-11-27 21:21       ` Stephen Rothwell
2010-11-28  0:22         ` Greg KH
     [not found] ` <1290927314_21183@mail4.comsite.net>
2010-12-01 18:30   ` Randy Dunlap [this message]
2010-12-01 19:29     ` The longest build error ever, ever, ever seen :) (Re:linux-next: " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101201103035.0e0b22cf.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle$(echo .)com \
    --cc=Valdis.Kletnieks@vt$(echo .)edu \
    --cc=gregkh@suse$(echo .)de \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=miltonm@bga$(echo .)com \
    --cc=napohybelskurwysynom2010@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox