Subject: Re: [PATCH 3/3 V13] RO/NX protection for loadable kernel

From: Rusty Russell <[email-masked]>
Date: Thu, 2 Dec 2010 00:06:45 +1030

On Wed, 1 Dec 2010 01:16:23 am Steven Rostedt wrote:
> On Tue, 2010-11-30 at 10:05 +1030, Rusty Russell wrote:
> > On Tue, 30 Nov 2010 04:45:42 am Steven Rostedt wrote:
> > > This patch breaks function tracer:
> > ...
> > > Here we set the text read only before we call the notifiers. The
> > > function tracer changes the calls to mcount into nops via a notifier
> > > call so this must be done after the module notifiers.
> > 
> > That seems fine.
> > 
> > I note that both before and after this patch we potentially execute code
> > in the module (via parse_args) before we set it ro & nx.  But fixing this
> > last bit of coverage is probably not worth the pain...
> 
> Rusty, can I take this as an "Acked-by"?

Yep... Acked-by: Rusty Russell <[email-masked]>

Thanks,
Rusty.