From: Randy Dunlap <randy.dunlap@oracle•com>
To: Zimny Lech <napohybelskurwysynom2010@gmail•com>,
gregkh@suse•de, akpm <akpm@linux-foundation•org>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Tomoya MORINAGA <tomoya-linux@dsn•okisemi.com>
Subject: [PATCH -next] serial: fix pch_uart kconfig & build
Date: Thu, 2 Dec 2010 09:19:48 -0800 [thread overview]
Message-ID: <20101202091948.2142bb5c.randy.dunlap@oracle.com> (raw)
In-Reply-To: <AANLkTi=aZ3Gm5rkqAh8j-bOvvKULge6Hm5cN_mEovVdq@mail.gmail.com>
From: Randy Dunlap <randy.dunlap@oracle•com>
The dma_request_channel/dma_release_channel interfaces are not
built when DMADEVICES is not enabled, so make the driver depend on
DMADEVICES. Also, the help text says that the driver enables & uses
PCH_DMA, which is not enabled, so select that.
ERROR: "__dma_request_channel" [drivers/serial/pch_uart.ko] undefined!
ERROR: "dma_release_channel" [drivers/serial/pch_uart.ko] undefined!
Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Tomoya MORINAGA <tomoya-linux@dsn•okisemi.com>
Reported-by: Zimny Lech <napohybelskurwysynom2010@gmail•com>
---
drivers/serial/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
This driver seems to have some other issues:
drivers/serial/pch_uart.c: In function 'dma_handle_rx':
drivers/serial/pch_uart.c:685: warning: cast from pointer to integer of different size
drivers/serial/pch_uart.c: In function 'dma_handle_tx':
drivers/serial/pch_uart.c:778: warning: cast from pointer to integer of different size
drivers/serial/pch_uart.c: In function 'pch_uart_init_port':
drivers/serial/pch_uart.c:1289: warning: cast to pointer from integer of different size
drivers/serial/pch_uart.c: In function 'pch_uart_exit_port':
drivers/serial/pch_uart.c:1328: warning: cast from pointer to integer of different size
--- linux-next-20101202.orig/drivers/serial/Kconfig
+++ linux-next-20101202/drivers/serial/Kconfig
@@ -1650,8 +1650,9 @@ config SERIAL_IFX6X60
config SERIAL_PCH_UART
tristate "Intel EG20T PCH UART"
+ depends on PCI && DMADEVICES
select SERIAL_CORE
- depends on PCI
+ select PCH_DMA
help
This driver is for PCH(Platform controller Hub) UART of Intel EG20T
which is an IOH(Input/Output Hub) for x86 embedded processor.
prev parent reply other threads:[~2010-12-02 17:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 3:09 linux-next: Tree for December 2 Stephen Rothwell
2010-12-02 13:52 ` Zimny Lech
2010-12-02 17:19 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101202091948.2142bb5c.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=gregkh@suse$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=napohybelskurwysynom2010@gmail$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tomoya-linux@dsn$(echo .)okisemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox