Subject: Re: linux-next: manual merge of the mfd tree with the ux500-core tree

From: Mark Brown <[email-masked]>
Date: Mon, 20 Dec 2010 12:12:16 +0000

On Mon, Dec 20, 2010 at 01:23:44PM +0900, Paul Mundt wrote:
> On Mon, Dec 20, 2010 at 03:21:48PM +1100, Stephen Rothwell wrote:

> > -static void tc3589x_irq_dummy(unsigned int irq)
> > +static void tc3589x_irq_dummy(struct irq_data *data)
> >  {
> >  	/* No mask/unmask at this level */
> >  }
> >  
> >  static struct irq_chip tc3589x_irq_chip = {
> > -	.name	= "tc3589x",
> > -	.mask	= tc3589x_irq_dummy,
> > -	.unmask	= tc3589x_irq_dummy,
> > +	.name		= "tc3589x",
> > +	.irq_mask	= tc3589x_irq_dummy,
> > +	.irq_unmask	= tc3589x_irq_dummy,
> >  };

> >  static int tc3589x_irq_init(struct tc3589x *tc3589x)

> Is there some reason you don't just kill this off and use dummy_irq_chip?

Mainly that I didn't take the time to read through the code and figure
out if it was doing anything interesting with the struct elsewhere
which meant this was actually sensible (one of the other drivers was
doing something surprising).