Subject: Re: linux-next: Tree for January 18 (__modver_version_show)

From: Dmitry Torokhov <[email-masked]>
Date: Wed, 19 Jan 2011 17:12:54 -0800

On Wed, Jan 19, 2011 at 04:59:54PM -0800, Randy Dunlap wrote:
> On 01/19/11 16:38, Dmitry Torokhov wrote:
> > On Wed, Jan 19, 2011 at 08:12:19AM -0800, Randy Dunlap wrote:
> >> On 01/19/11 08:10, Randy Dunlap wrote:
> >>> On 01/18/11 21:09, Stephen Rothwell wrote:
> >>>> Hi Randy,
> >>>>
> >>>> On Tue, 18 Jan 2011 09:17:49 -0800 Randy Dunlap <[email-masked]> wrote:
> >>>>>
> >>>>> I'm seeing this on several builds (i386 and x86_64):
> >>>>>
> >>>>> lib/built-in.o:(__modver+0x8): undefined reference to `__modver_version_show'
> >>>>> lib/built-in.o:(__modver+0x2c): undefined reference to `__modver_version_show'
> >>>>>
> >>>>> It looks like the compiler or linker is dropping that function from the
> >>>>> build since it cannot see any references to it...
> >>>>> At least __modver_version_show is not in the kernel/params.o file.
> >>>>
> >>>> Do these builds have CONFIG_SYSFS set?
> >>>>
> >>>
> >>> Yes, they all do (50 random builds have CONFIG_SYSFS=y).
> >>
> >> Gawd, what bad grepping this morning.
> >>
> >> You hit the nail.  They do not have SYSFS enabled.
> >>
> > 
> > Argh, this one is my fault, the following should fix it.
> > 
> 
> Acked-by: Randy Dunlap <[email-masked]>
> 

Great!

Hopefully Rusty will be able to fold it in the original change so it
won't break bisects.

-- 
Dmitry