Subject: Re: [PATCH V4] Export ACPI _DSM provided firmware instance number and string name to sysfs

From: Greg KH <[email-masked]>
Date: Mon, 7 Mar 2011 11:56:16 -0800

On Mon, Mar 07, 2011 at 11:44:52AM -0800, [email-masked] wrote:
> --- a/drivers/pci/pci-label.c
> +++ b/drivers/pci/pci-label.c
> @@ -29,7 +29,9 @@
>  #include <linux/nls.h>
>  #include <linux/acpi.h>
>  #include <linux/pci-acpi.h>
> +#ifdef CONFIG_ACPI
>  #include <acpi/acpi_drivers.h>
> +#endif

You should never need a #ifdef in a .c file for an include file.  If so,
something is really wrong.

thanks,

greg k-h