Subject: Re: [PATCH v7] MAX8997/8966 MFD: Add IRQ control feature

From: Samuel Ortiz <[email-masked]>
Date: Tue, 22 Mar 2011 12:51:35 +0100

Hi MyungJoo,

On Mon, Mar 21, 2011 at 05:08:24PM +0900, MyungJoo Ham wrote:
> +static struct irq_chip max8997_irq_chip = {
> +	.name			= "max8997",
> +#ifdef CONFIG_GENERIC_HARDIRQS_NO_DEPRECATED
> +	.irq_bus_lock		= max8997_irq_lock,
> +	.irq_bus_sync_unlock	= max8997_irq_sync_unlock,
> +	.irq_mask		= max8997_irq_mask,
> +	.irq_unmask		= max8997_irq_unmask,
> +#else /* CONFIG_GENERIC_HARDIRQS_NO_DEPRECATED */
> +	.bus_lock		= max8997_irq_lock,
> +	.bus_sync_unlock	= max8997_irq_sync_unlock,
> +	.mask			= max8997_irq_mask,
> +	.unmask			= max8997_irq_unmask,
> +#endif /* CONFIG_GENERIC_HARDIRQS_NO_DEPRECATED */
> +};
You actually don't need to define both pointer sets. Setting the irq_* ones
should be enough for both configs.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/