From: Randy Dunlap <randy.dunlap@oracle•com>
To: Jesse Barnes <jbarnes@virtuousgeek•org>
Cc: Matthew Garrett <mjg59@srcf•ucam.org>,
Narendra_K@Dell•com, viro@zeniv•linux.org.uk,
sfr@canb•auug.org.au, linux-kernel@vger•kernel.org,
linux-next@vger•kernel.org, Shyam_Iyer@Dell•com,
Matt_Domsch@Dell•com, Charles_Rose@Dell•com,
Jordan_Hargrave@Dell•com
Subject: Re: [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig
Date: Mon, 28 Mar 2011 08:02:20 -0700 [thread overview]
Message-ID: <20110328080220.1390d28e.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20110304101509.7eef7475@jbarnes-desktop>
On Fri, 4 Mar 2011 10:15:09 -0800 Jesse Barnes wrote:
> On Wed, 23 Feb 2011 13:17:34 +0000
> Matthew Garrett <mjg59@srcf•ucam.org> wrote:
>
> > On Wed, Feb 23, 2011 at 06:24:31PM +0530, Narendra_K@Dell•com wrote:
> >
> > > This patch fixes the following build breakage introduced by the patch
> > > '[PATCH V3] Export ACPI _DSM provided firmware instance number and string to
> > > sysfs'.
> >
> > First, you should include this as part of your original patch so that
> > the build doesn't break during bisection.
> >
> > > This is fixed by making fs/nls/nls_base.c compile conditionally into
> > > vmlinux by introducing a new config option CONFIG_NLS_BASE which is
> > > selected by (ACPI || DMI || NLS).
> >
> > Why?
> >
> > > -obj-$(CONFIG_NLS) += nls/
> > > +obj-y += nls/
> >
> > You seem to have just broken building any of the NLS code as modules.
> >
> > > menuconfig NLS
> > > tristate "Native language support"
> > > + select NLS_BASE
> >
> > All CONFIG_NLS does is build nls_base.
> >
> > > +config NLS_BASE
> > > + bool "Base NLS functions"
> > > + depends on ACPI || DMI
> >
> > What in this code depends on ACPI or DMI?
> >
> > > -obj-$(CONFIG_NLS) += nls_base.o
> > > +obj-$(CONFIG_NLS_BASE) += nls_base.o
> >
> > And why make this change?
> >
> > Just have something like
> >
> > select NLS if (ACPI || DMI)
> >
> > in drivers/pci/Kconfig.
>
> Narendra, can you send me an updated patch including the build fix?
> Either using this approach or the other one I outlined in my other mail.
This driver still has build failures in linux-next 20110328.
pci-label.c:(.text+0x9a40): undefined reference to `utf16s_to_utf8s'
CONFIG_NLS=m
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2011-03-28 15:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 12:54 [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig Narendra_K
2011-02-23 13:17 ` Matthew Garrett
2011-03-04 18:15 ` Jesse Barnes
2011-03-28 15:02 ` Randy Dunlap [this message]
2011-03-28 16:17 ` Jesse Barnes
2011-03-28 19:14 ` Shyam_Iyer
2011-03-28 20:22 ` Randy Dunlap
2011-03-29 1:55 ` OGAWA Hirofumi
2011-03-29 16:18 ` Randy Dunlap
2011-03-29 16:23 ` Jesse Barnes
2011-03-29 16:39 ` OGAWA Hirofumi
2011-03-29 16:45 ` [PATCH] pci-label: " Randy Dunlap
2011-03-29 16:55 ` Jesse Barnes
2011-03-31 9:27 ` Narendra_K
2011-04-19 6:06 ` [PATCH] " Ingo Molnar
2011-04-19 8:43 ` Narendra_K
2011-04-19 16:25 ` Jesse Barnes
-- strict thread matches above, loose matches on Subject: below --
2011-01-12 20:10 CONFIG_NLS=m resulting in undefined reference to utf16s_to_utf8s causing build failure Narendra_K
2011-01-13 0:02 ` Jesse Barnes
2011-01-13 3:23 ` Len Brown
2011-01-13 15:55 ` Jesse Barnes
2011-01-13 16:03 ` Narendra_K
2011-01-14 15:22 ` [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig Narendra_K
2011-01-14 15:29 ` Sedat Dilek
2011-01-14 16:06 ` Narendra_K
2011-01-14 21:09 ` Stephen Rothwell
2011-01-17 19:28 ` Narendra_K
2011-01-20 18:41 ` Narendra_K
2011-01-28 15:30 ` Narendra_K
2011-01-28 16:45 ` Jesse Barnes
2011-02-01 16:28 ` Narendra_K
2011-02-01 16:59 ` Narendra_K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328080220.1390d28e.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=Charles_Rose@Dell$(echo .)com \
--cc=Jordan_Hargrave@Dell$(echo .)com \
--cc=Matt_Domsch@Dell$(echo .)com \
--cc=Narendra_K@Dell$(echo .)com \
--cc=Shyam_Iyer@Dell$(echo .)com \
--cc=jbarnes@virtuousgeek$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mjg59@srcf$(echo .)ucam.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=viro@zeniv$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox