From: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public•gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public•gmane.org>,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public•gmane.org>
Cc: Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public•gmane.org>,
Randy Dunlap
<randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public•gmane.org>,
Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public•gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-next-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>
Subject: Re: [PATCH -next reresend] i2c: designware-pcidrv depends on PCI
Date: Wed, 13 Apr 2011 08:38:55 +1000 [thread overview]
Message-ID: <20110413083855.c37ddadc.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20110412114722.0f2e67d6-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 2071 bytes --]
Hi Jean, Ben,
On Tue, 12 Apr 2011 11:47:22 +0200 Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public•gmane.org> wrote:
>
> On Sat, 9 Apr 2011 13:34:49 +0200, Geert Uytterhoeven wrote:
> > On Fri, Apr 8, 2011 at 17:32, Randy Dunlap <randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public•gmane.org> wrote:
> > > From: Randy Dunlap <randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public•gmane.org>
> > >
> > > i2c-designware-pcidrv is a PCI driver and should depend on PCI.
> > > Fixes these build errors:
> > >
> > > drivers/i2c/busses/i2c-designware-pcidrv.c:256: error: implicit declaration of function 'pci_request_region'
> > > drivers/i2c/busses/i2c-designware-pcidrv.c:338: error: implicit declaration of function 'pci_release_region'
> > >
> > > Signed-off-by: Randy Dunlap <randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public•gmane.org>
> > > Cc: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public•gmane.org>
> > > ---
> > > drivers/i2c/busses/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > Does anybody merge i2c patches???
> >
> > Yes please, it's been there since Mar 17, reported several times, and probably
> > masking other build failures.
>
> This bug only exists in linux-next, as the code in question wasn't
> merged in Linus's tree yet. It is drawn into linux-next from Ben
> Dooks's next-i2c branch:
> http://git.fluff.org/gitweb?p=bjdooks/linux.git;a=shortlog;h=refs/heads/next-i2c
>
> This is where it has to be fixed, so only Ben can do it. Ben, please?
>
> Meanwhile, it should be possible to apply a hot fix to linux-next
> directly, Stephen does it pretty often. Stephen, could you please apply
> this fix temporarily until Ben wakes up and applies it to his tree?
I will apply this patch as a merge fixup from today (if it is still
needed). I also have a patch being applied to that tree to add an
include of linux/delay.h to drivers/i2c/busses/i2c-designware-core.c .
Ben?
--
Cheers,
Stephen Rothwell sfr-3FnU+UHB4dNDw9hX6IcOSA@public•gmane.org
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-04-12 22:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 15:32 [PATCH -next reresend] i2c: designware-pcidrv depends on PCI Randy Dunlap
2011-04-09 11:34 ` Geert Uytterhoeven
2011-04-12 9:47 ` Jean Delvare
2011-04-12 15:48 ` Randy Dunlap
[not found] ` <20110412114722.0f2e67d6-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-04-12 22:38 ` Stephen Rothwell [this message]
2011-04-19 21:45 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110413083855.c37ddadc.sfr@canb.auug.org.au \
--to=sfr-3fnu+uhb4dndw9hx6icosa@public$(echo .)gmane.org \
--cc=baruch-NswTu9S1W3P6gbPvEgmw2w@public$(echo .)gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public$(echo .)gmane.org \
--cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public$(echo .)gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public$(echo .)gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox