public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime•net>
To: Stephen Rothwell <sfr@canb•auug.org.au>, Takashi Iwai <tiwai@suse•de>
Cc: linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>
Subject: Re: linux-next: Tree for April 20
Date: Wed, 20 Apr 2011 11:02:24 -0700	[thread overview]
Message-ID: <20110420110224.e3974722.rdunlap@xenotime.net> (raw)
In-Reply-To: <20110420144329.fce0e28e.sfr@canb.auug.org.au>

On Wed, 20 Apr 2011 14:43:29 +1000 Stephen Rothwell wrote:

> Hi all,

> Merging sound/for-next
> Merging sound-asoc/for-next

Takashi,

mainline contains commit a2800300f28bd1814f3ba8cfd93ecb0b00c2dfe3
Author: Takashi Iwai <tiwai@suse•de>
Date:   Tue Mar 8 18:20:46 2011 +0100
    ALSA: asihpi - Use %zd for size_t argument in error message

which changes:
--- a/sound/pci/asihpi/hpi6205.c
+++ b/sound/pci/asihpi/hpi6205.c
@@ -2088,7 +2088,7 @@ static u16 message_response_sequence(struct hpi_adapter_ob
j *pao,
 		phr->specific_error = sizeof(interface->u);
 		phr->size = sizeof(struct hpi_response_header);
 		HPI_DEBUG_LOG(ERROR,
-			"message len %d too big for buffer %ld \n", phm->size,
+			"message len %d too big for buffer %zd \n", phm->size,
 			sizeof(interface->u));
 		return 0;
 	}


However, it looks like there is a patch in your for-next branch which undoes
that commit, since hpi6205.c still uses %ld to print the sizeof() value and this
warning is still produced:

linux-next-20110420/sound/pci/asihpi/hpi6205.c:2091: warning: format '%ld' expects type 'long int', but argument 3 has type 'unsigned int'


Please drop at least that one line from for-next.

or am I completely befuddled?

thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  reply	other threads:[~2011-04-20 18:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-20  4:43 linux-next: Tree for April 20 Stephen Rothwell
2011-04-20 18:02 ` Randy Dunlap [this message]
2011-04-20 19:01   ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2009-04-20  4:10 Stephen Rothwell
2009-04-20 10:29 ` Nico -telmich- Schottelius

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110420110224.e3974722.rdunlap@xenotime.net \
    --to=rdunlap@xenotime$(echo .)net \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=sfr@canb$(echo .)auug.org.au \
    --cc=tiwai@suse$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox