Subject: Re: linux-next: Tree for April 21 (i82975x_edac)

From: Randy Dunlap <[email-masked]>
Date: Thu, 21 Apr 2011 08:51:24 -0700

On Thu, 21 Apr 2011 13:20:45 +1000 Stephen Rothwell wrote:

> Changes since 20110420:

on i386:

drivers/edac/i82975x_edac.c:298: warning: integer constant is too large for 'unsigned long' type

which is:

	if (info->xeap & 1)
		page |= 0x100000000ul; <<<<<<<<<<<<<<<

but page is unsigned long (32 bits), while 0x100000000ul is more than 32 bits,
so that line isn't setting a bit in <page>.  Is it a bug, or this driver isn't
applicable to X86_32, or what?

thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***