From: Randy Dunlap <randy.dunlap@oracle•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
Pavan Savoy <pavan_savoy@ti•com>
Cc: linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
gregkh@suse•de
Subject: [PATCH -next] misc: fix ti-st build issues
Date: Tue, 26 Apr 2011 09:18:51 -0700 [thread overview]
Message-ID: <20110426091851.87edcef3.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20110426202605.c66ce0ea.sfr@canb.auug.org.au>
From: Randy Dunlap <randy.dunlap@oracle•com>
st_drv uses skb*() interfaces, so it should depend on NET.
It also uses GPIO interfaces, so it should depend on GPIOLIB.
st_kim.c uses syss_*() calls, so it should #include
<linux/sysfs.h>.
Fixes these observed build errors:
ERROR: "skb_queue_purge" [drivers/misc/ti-st/st_drv.ko] undefined!
ERROR: "skb_pull" [drivers/misc/ti-st/st_drv.ko] undefined!
ERROR: "skb_queue_tail" [drivers/misc/ti-st/st_drv.ko] undefined!
ERROR: "__alloc_skb" [drivers/misc/ti-st/st_drv.ko] undefined!
ERROR: "kfree_skb" [drivers/misc/ti-st/st_drv.ko] undefined!
ERROR: "skb_dequeue" [drivers/misc/ti-st/st_drv.ko] undefined!
ERROR: "skb_put" [drivers/misc/ti-st/st_drv.ko] undefined!
Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Pavan Savoy <pavan_savoy@ti•com>
---
drivers/misc/ti-st/Kconfig | 1 +
drivers/misc/ti-st/st_kim.c | 1 +
2 files changed, 2 insertions(+)
--- linux-next-20110426.orig/drivers/misc/ti-st/Kconfig
+++ linux-next-20110426/drivers/misc/ti-st/Kconfig
@@ -5,6 +5,7 @@
menu "Texas Instruments shared transport line discipline"
config TI_ST
tristate "Shared transport core driver"
+ depends on NET && GPIOLIB
select FW_LOADER
help
This enables the shared transport core driver for TI
--- linux-next-20110426.orig/drivers/misc/ti-st/st_kim.c
+++ linux-next-20110426/drivers/misc/ti-st/st_kim.c
@@ -30,6 +30,7 @@
#include <linux/debugfs.h>
#include <linux/seq_file.h>
#include <linux/sched.h>
+#include <linux/sysfs.h>
#include <linux/tty.h>
#include <linux/skbuff.h>
prev parent reply other threads:[~2011-04-26 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 10:26 linux-next: Tree for April 26 Stephen Rothwell
2011-04-26 15:38 ` linux-next: Tree for April 26 (x86 mmu) (resend) Randy Dunlap
2011-04-26 15:39 ` linux-next: Tree for April 26 (kvm) (resend) Randy Dunlap
2011-04-27 7:49 ` linux-next: Tree for April 26 (kvm) Avi Kivity
2011-04-26 16:18 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110426091851.87edcef3.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=gregkh@suse$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=pavan_savoy@ti$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox