From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Dave Jones <davej@redhat•com>
Cc: Michal Marek <mmarek@suse•cz>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Sam Ravnborg <sam@ravnborg•org>
Subject: Re: linux-next: build warning after merge of the kbuild tree
Date: Mon, 2 May 2011 13:45:24 +1000 [thread overview]
Message-ID: <20110502134524.40da4245.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20110502022417.GA11804@redhat.com>
Hi Dave,
On Sun, 1 May 2011 22:24:18 -0400 Dave Jones <davej@redhat•com> wrote:
>
> Which version of the patch got merged ? This should be guarded by cc-option checks.
It looks right to me (that's why I wrote "though I don't see why") but
empirically we have a problem.
This is what is in -next today:
From: Dave Jones <davej@redhat•com>
Date: Thu, 21 Apr 2011 17:28:13 -0400
Subject: [PATCH] kbuild: Disable -Wunused-but-set-variable for gcc 4.6.0
Disable the new -Wunused-but-set-variable that was added in gcc 4.6.0
It produces more false positives than useful warnings.
This can still be enabled using W=1
Signed-off-by: Dave Jones <davej@redhat•com>
Acked-by: Sam Ravnborg <sam@ravnborg•org>
Tested-by: Sam Ravnborg <sam@ravnborg•org>
Signed-off-by: Michal Marek <mmarek@suse•cz>
---
Makefile | 4 ++++
scripts/Makefile.build | 1 +
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index e509cc7..4527dc2 100644
--- a/Makefile
+++ b/Makefile
@@ -567,6 +567,10 @@ ifndef CONFIG_CC_STACKPROTECTOR
KBUILD_CFLAGS += $(call cc-option, -fno-stack-protector)
endif
+# This warning generated too much noise in a regular build.
+# Use make W=1 to enable this warning (see scripts/Makefile.build)
+KBUILD_CFLAGS += $(call cc-option, -Wno-unused-but-set-variable)
+
ifdef CONFIG_FRAME_POINTER
KBUILD_CFLAGS += -fno-omit-frame-pointer -fno-optimize-sibling-calls
else
diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 9c0c481..9fb19c0 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -66,6 +66,7 @@ warning-1 += -Wmissing-format-attribute
warning-1 += -Wmissing-prototypes
warning-1 += -Wold-style-definition
warning-1 += $(call cc-option, -Wmissing-include-dirs)
+warning-1 += $(call cc-option, -Wunused-but-set-variable)
warning-2 := -Waggregate-return
warning-2 += -Wcast-align
--
1.7.4.4
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
next prev parent reply other threads:[~2011-05-02 3:45 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 2:18 linux-next: build warning after merge of the kbuild tree Stephen Rothwell
2011-05-02 2:24 ` Dave Jones
2011-05-02 3:45 ` Stephen Rothwell [this message]
2011-05-02 4:02 ` Dave Jones
2011-05-02 4:44 ` Stephen Rothwell
2011-05-02 4:24 ` Stephen Rothwell
2011-05-02 4:36 ` Dave Jones
2011-05-02 5:57 ` Stephen Rothwell
2011-05-02 4:53 ` Stephen Rothwell
2011-05-02 11:13 ` Michal Marek
2011-05-02 12:13 ` [PATCH] kbuild: Fix passing -Wno-* options to gcc 4.4+ Michal Marek
2011-05-03 0:44 ` Stephen Rothwell
2011-05-03 8:52 ` Michal Marek
2011-05-02 15:17 ` linux-next: build warning after merge of the kbuild tree Valdis.Kletnieks
2011-05-02 15:31 ` Michal Marek
-- strict thread matches above, loose matches on Subject: below --
2025-07-30 6:40 Stephen Rothwell
2025-08-05 3:31 ` Stephen Rothwell
2025-06-06 4:01 Stephen Rothwell
2025-06-07 5:38 ` Masahiro Yamada
2025-05-26 8:03 Stephen Rothwell
2025-06-03 23:02 ` Stephen Rothwell
2025-06-04 1:37 ` Randy Dunlap
2024-09-09 0:54 Stephen Rothwell
2023-10-03 23:13 Stephen Rothwell
2023-08-28 4:57 Stephen Rothwell
2023-08-28 17:28 ` Nick Desaulniers
2021-08-19 23:28 Stephen Rothwell
2021-08-23 0:25 ` Masahiro Yamada
2020-12-20 22:10 Stephen Rothwell
2020-12-09 9:30 Stephen Rothwell
2020-12-09 13:01 ` Dominique Martinet
2020-12-09 20:56 ` Stephen Rothwell
2020-12-10 6:47 ` Dominique Martinet
2020-12-14 20:44 ` Stephen Rothwell
2017-12-10 22:52 Stephen Rothwell
2017-12-11 0:22 ` Masahiro Yamada
2017-12-11 16:11 ` Bart Van Assche
2016-11-30 23:06 Stephen Rothwell
2016-12-01 2:00 ` Nicholas Piggin
2010-12-23 0:00 Stephen Rothwell
2010-09-30 0:52 Stephen Rothwell
2010-09-30 20:24 ` Michal Marek
2010-09-30 0:50 Stephen Rothwell
2010-09-30 20:25 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110502134524.40da4245.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=davej@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mmarek@suse$(echo .)cz \
--cc=sam@ravnborg$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox