From: Greg KH <greg@kroah•com>
To: Mitch Harder <mitch.harder@sabayonlinux•org>,
dave@jikos•cz, Stephen Rothwell <sfr@canb•auug.org.au>,
Chris Mason <chris.mason@oracle•com>,
linux-next@vger•kernel.org, linux-kernel@vg
Subject: Re: linux-next: build warninga in Linus' tree
Date: Fri, 3 Jun 2011 22:16:28 +0900 [thread overview]
Message-ID: <20110603131628.GB7355@kroah.com> (raw)
In-Reply-To: <20110603111048.GR12709@twin.jikos.cz>
On Fri, Jun 03, 2011 at 01:10:49PM +0200, David Sterba wrote:
> On Wed, Jun 01, 2011 at 10:16:48AM -0500, Mitch Harder wrote:
> > I've been playing around with resurrecting the basic sysfs
> > capabilities that had been previously incorporated into btrfs.
> >
> > As it stands right now, it was relatively easy to re-implement sysfs
> > as it was originally. However, that implementation of sysfs wasn't
> > populated with much information (only total_blocks, blocks_used, and
> > blocksize).
>
> Goffredo Baroncelli (CCed) posted a patch to enhance sysfs interface:
>
> https://patchwork.kernel.org/patch/308902/
> (http://www.spinics.net/lists/linux-btrfs/msg06777.html)
>
> > I also had to reverse a small portion of code that was in the last
> > clean-up.
>
> Restoring the code should not be a problem, the cleanup was too eager
> and I think a sysfs inteface would be good, not only for debugging
> purposes or tuning.
>
> > If a CONFIG_BTRFS_DEBUG type configuration flag is ever introduced, it
> > would be interesting to resurrect btrfs' sysfs capabilities.
>
> Hearing about CONFIG_BTRFS_DEBUG again, seems worth to add it.
For debugging stuff, please use debugfs instead of sysfs, as that is
what it is there for.
thanks,
greg k-h
next prev parent reply other threads:[~2011-06-03 13:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 1:36 linux-next: build warninga in Linus' tree Stephen Rothwell
2011-05-31 17:57 ` David Sterba
2011-06-01 15:16 ` Mitch Harder
2011-06-03 11:10 ` David Sterba
2011-06-03 11:38 ` Hugo Mills
2011-06-03 13:16 ` Greg KH [this message]
2011-06-03 12:25 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110603131628.GB7355@kroah.com \
--to=greg@kroah$(echo .)com \
--cc=chris.mason@oracle$(echo .)com \
--cc=dave@jikos$(echo .)cz \
--cc=linux-kernel@vg \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mitch.harder@sabayonlinux$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox