From: "Henry Ptasinski" <henryp@broadcom•com>
To: Greg KH <greg@kroah•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Brett Rudley <brudley@broadcom•com>,
Roland Vossen <rvossen@broadcom•com>,
"linux-next@vger•kernel.org" <linux-next@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
Linus <torvalds@linux-foundation•org>,
Henry Ptasinski <henryp@broadcom•com>
Subject: Re: linux-next: build failure after merge of the final tree (staging related)
Date: Thu, 9 Jun 2011 12:52:12 -0700 [thread overview]
Message-ID: <20110609195211.GG10107@broadcom.com> (raw)
In-Reply-To: <20110609184127.GA2760@kroah.com>
On Thu, Jun 09, 2011 at 11:41:27AM -0700, Greg KH wrote:
> On Thu, Jun 09, 2011 at 05:27:45PM +1000, Stephen Rothwell wrote:
> > Hi Greg,
> >
> > After merging the final tree, today's linux-next build (powerpc allyesconfig)
> > failed like this:
> >
> > drivers/staging/brcm80211/brcmsmac/ampdu.c: In function 'wlc_ampdu_dotxstatus':
> > drivers/staging/brcm80211/brcmsmac/ampdu.c:840:17: error: invalid operands to binary ^ (have 'volatile u32 *' and 'int')
> > drivers/staging/brcm80211/brcmsmac/ampdu.c:840:17: error: invalid operands to binary ^ (have 'volatile u32 *' and 'int')
> > drivers/staging/brcm80211/brcmsmac/ampdu.c:848:8: error: invalid operands to binary ^ (have 'volatile u32 *' and 'int')
> > drivers/staging/brcm80211/brcmsmac/ampdu.c:848:8: error: invalid operands to binary ^ (have 'volatile u32 *' and 'int')
> > drivers/staging/brcm80211/brcmsmac/bmac.c: In function 'wlc_bmac_update_slot_timing':
> > drivers/staging/brcm80211/brcmsmac/bmac.c:186:3: error: invalid operands to binary ^ (have 'volatile u16 *' and 'int')
> > drivers/staging/brcm80211/brcmsmac/bmac.c:186:3: error: invalid operands to binary ^ (have 'volatile u16 *' and 'int')
> > drivers/staging/brcm80211/brcmsmac/bmac.c:190:3: error: invalid operands to binary ^ (have 'volatile u16 *' and 'int')
> > drivers/staging/brcm80211/brcmsmac/bmac.c:190:3: error: invalid operands to binary ^ (have 'volatile u16 *' and 'int')
> > drivers/staging/brcm80211/brcmsmac/bmac.c: In function 'wlc_setband_inact':
> > drivers/staging/brcm80211/brcmsmac/bmac.c:234:2: error: invalid operands to binary ^ (have 'volatile u32 *' and 'int')
> > drivers/staging/brcm80211/brcmsmac/bmac.c:234:2: error: invalid operands to binary ^ (have 'volatile u32 *' and 'int')
> > drivers/staging/brcm80211/brcmsmac/bmac.c: In function 'wlc_dpc':
> > drivers/staging/brcm80211/brcmsmac/bmac.c:311:6: error: invalid operands to binary ^ (have 'volatile u32 *' and 'int')
> >
> > (and lots more)
>
> Fun :(
>
> This looks messy. It's a macro that is trying to be cute by doing:
> #define R_REG(r) \
> ({ \
> __typeof(*(r)) __osl_v; \
> __asm__ __volatile__("sync"); \
> __osl_v = bcmsdh_reg_read(NULL, (unsigned long)(r),\
> sizeof(*(r))); \
> __asm__ __volatile__("sync"); \
> __osl_v; \
> })
>
> on big-endian, non-mips platforms. Which I really doubt has ever
> been tested before.
I think it was used on PPC once upon a time, but likely in a very different
incarnation.
> Roland, Brett, any thoughts?
>
> Should I just disable this module from being build on PPC as it doesn't
> look like its ever been tested or run on that platform before.
Disabling the build on PPC for now sounds ok. We'll work on cleaning up the
macros and try to get some more platform test coverage.
- Henry
next prev parent reply other threads:[~2011-06-09 19:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 7:27 linux-next: build failure after merge of the final tree (staging related) Stephen Rothwell
2011-06-09 18:41 ` Greg KH
2011-06-09 19:22 ` Greg KH
2011-06-10 6:05 ` Stephen Rothwell
2011-06-10 6:09 ` Stephen Rothwell
2011-06-10 22:34 ` Greg KH
2011-06-15 4:21 ` Stephen Rothwell
2011-06-16 19:14 ` Greg KH
2011-06-23 0:35 ` Stephen Rothwell
2011-06-23 21:51 ` Greg KH
2011-06-24 0:00 ` Stephen Rothwell
2011-06-27 21:45 ` Greg KH
2011-06-28 0:16 ` Stephen Rothwell
2011-06-15 12:05 ` Geert Uytterhoeven
2011-06-15 15:47 ` Greg KH
2011-06-15 14:35 ` [PATCH] arch/tile: remove useless set_fixmap_nocache() macro Chris Metcalf
2011-06-09 19:52 ` Henry Ptasinski [this message]
2011-06-09 20:19 ` linux-next: build failure after merge of the final tree (staging related) Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110609195211.GG10107@broadcom.com \
--to=henryp@broadcom$(echo .)com \
--cc=brudley@broadcom$(echo .)com \
--cc=greg@kroah$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rvossen@broadcom$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox