Subject: Re: linux-next: build failure after merge of the final tree (staging related)

From: Stephen Rothwell <[email-masked]>
Date: Fri, 10 Jun 2011 16:09:38 +1000

Hi Greg,

On Fri, 10 Jun 2011 16:05:48 +1000 Stephen Rothwell <[email-masked]> wrote:
>
> No, I still get these:
> 
> In file included from drivers/staging/comedi/drivers/addi_apci_035.c:7:0:
> drivers/staging/comedi/drivers/addi-data/addi_common.c: In function 'i_ADDI_Attach':
> drivers/staging/comedi/drivers/addi-data/addi_common.c:2765:7: error: implicit declaration of function 'virt_to_bus'
> 
> virt_to_bus is only defined for 32 bit powerpc (not 64 bit) (and maybe
> not at all on some architectures e.g. sparc).
> 
> From Documentation/DMA-API-HOWTO.txt:
> "All drivers should be using these interfaces with no exceptions.  It
> is planned to completely remove virt_to_bus() and bus_to_virt() as
> they are entirely deprecated.  Some ports already do not provide these
> as it is impossible to correctly support them."

Drivers that use virt_to_bus should Kconfig depend on VIRT_TO_BUS.

-- 
Cheers,
Stephen Rothwell                    [email-masked]
http://www.canb.auug.org.au/~sfr/