From: Randy Dunlap <randy.dunlap@oracle•com>
To: Grant Likely <grant.likely@secretlab•ca>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
alsa-devel@alsa-project•org, x86@kernel•org,
Dmitry Artamonow <mad_soft@inbox•ru>,
Mark Brown <broonie@opensource•wolfsonmicro.com>,
LKML <linux-kernel@vger•kernel.org>,
linux-next@vger•kernel.org, Harald Welte <laforge@gnufiish•org>
Subject: Re: [PATCH] gpio: add GPIOF_ values regardless on kconfig settings
Date: Tue, 14 Jun 2011 17:03:21 -0700 [thread overview]
Message-ID: <20110614170321.10e1caa7.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20110614161357.GB1839@ponder.secretlab.ca>
On Tue, 14 Jun 2011 10:13:57 -0600 Grant Likely wrote:
> On Tue, Jun 14, 2011 at 09:12:11AM -0700, Randy Dunlap wrote:
> > On Sun, 05 Jun 2011 20:45:43 -0700 Randy Dunlap wrote:
> >
> > > On 06/03/11 10:42, Grant Likely wrote:
> > > > On Fri, Jun 3, 2011 at 11:18 AM, Mark Brown
> > > > <broonie@opensource•wolfsonmicro.com> wrote:
> > > >> On Fri, Jun 03, 2011 at 11:04:52AM -0600, Grant Likely wrote:
> > > >>
> > > >>> I ended up not pushing this one to Linus. Turns out it causes other
> > > >>> breakage on other platforms that don't include include/linux/gpio.h.
> > > >>> Since I don't have confidence that I'll be able to find all the
> > > >>> offenders, I'm dropping it. I recommend making any drivers that are
> > > >>
> > > >> So, this originally came about because I pushed back on adding random
> > > >> dependencies like this for features which are pretty much optional in
> > > >> drivers - their use of GPIOs is totally optional and the dependencies
> > > >> are just too fragile, leading to noise with all the randconfigs. It
> > > >> seems better to get the architectures to keep up with enhancements to
> > > >> gpiolib (or convert to it) than to have to worry about this in drivers.
> > > >
> > > > Fair enough. Randy, if you or someone else can check that all GPIOF_
> > > > users have the required #include <linux/gpio.h>, then I'm okay with
> > > > this patch.
> > >
> > > OK, I'll look at that.
> >
> > Of the 70 files that use GPIOF_ macros:
> >
> > hdr missing in: ./arch/arm/mach-pxa/spitz_pm.c
> > hdr missing in: ./arch/avr32/mach-at32ap/pio.c
> > hdr missing in: ./arch/avr32/mach-at32ap/include/mach/portmux.h
> > hdr missing in: ./arch/avr32/boards/hammerhead/setup.c
> > hdr missing in: ./arch/avr32/boards/hammerhead/flash.c
> > hdr missing in: ./arch/avr32/boards/mimc200/setup.c
> > hdr missing in: ./arch/avr32/boards/atstk1000/setup.c
> > hdr missing in: ./drivers/pcmcia/pxa2xx_vpac270.c
> >
> >
> > > Do you have any examples of builds that failed with this patch?
> >
> > and would you merge patch(es) that add this header file to those source
> > files? If not, I'll need to make 3 separate patches for them.
That list of files above is incorrect. Bad grep pattern.
Drop all of the avr32 files. Ending patch is small -- sending it soon.
> Yes I would. I'm fine with it all being one patch.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2011-06-15 0:03 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 5:45 linux-next: Tree for May 23 Stephen Rothwell
2011-05-23 16:42 ` linux-next: Tree for May 23 (infiniband + netlink) Randy Dunlap
[not found] ` <20110523094205.4a5651d2.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2011-05-23 18:05 ` Roland Dreier
2011-05-23 17:43 ` [PATCH -next] x86: apic_flat_64.c needs module.h Randy Dunlap
2011-05-23 17:51 ` Cyrill Gorcunov
2011-05-23 18:09 ` Cyrill Gorcunov
2011-05-23 18:12 ` Randy Dunlap
2011-05-23 18:35 ` Cyrill Gorcunov
2011-05-23 19:10 ` Ingo Molnar
2011-05-23 19:26 ` Ingo Molnar
2011-05-23 17:49 ` linux-next: Tree for May 23 (hwmon/coretemp.c) Randy Dunlap
2011-05-23 18:03 ` Guenter Roeck
2011-05-23 18:35 ` [PATCH -next] target: fix tfc_io.c printk format warning Randy Dunlap
2011-05-23 20:47 ` Nicholas A. Bellinger
2011-06-16 18:35 ` Randy Dunlap
2011-05-23 18:37 ` [PATCH -next] mtd: fix physmap.h warnings Randy Dunlap
2011-05-24 5:53 ` Artem Bityutskiy
2011-05-24 5:58 ` Artem Bityutskiy
2011-05-24 7:40 ` Russell King
2011-05-24 7:40 ` Artem Bityutskiy
2011-05-24 7:42 ` Artem Bityutskiy
2011-06-01 7:45 ` Artem Bityutskiy
2011-06-01 8:05 ` Russell King
2011-05-24 7:41 ` Artem Bityutskiy
2011-05-23 20:48 ` linux-next: Tree for May 23 (sound/soc/codecs) Randy Dunlap
2011-05-23 22:47 ` Mark Brown
2011-05-23 22:53 ` Randy Dunlap
2011-05-24 0:08 ` Mark Brown
2011-05-24 1:21 ` Randy Dunlap
2011-05-24 1:50 ` Mark Brown
2011-05-24 4:58 ` [PATCH/RFC] gpio: add GPIOF_ values regardless on kconfig settings Randy Dunlap
2011-05-24 5:23 ` Dmitry Artamonow
2011-05-24 19:44 ` Randy Dunlap
2011-05-24 7:52 ` Mark Brown
2011-05-27 7:45 ` [alsa-devel] " Grant Likely
2011-05-27 17:46 ` [PATCH] " Randy Dunlap
2011-05-27 20:12 ` Grant Likely
2011-06-03 17:04 ` Grant Likely
2011-06-03 17:18 ` Mark Brown
2011-06-03 17:42 ` Grant Likely
2011-06-06 3:45 ` Randy Dunlap
2011-06-14 16:12 ` Randy Dunlap
2011-06-14 16:13 ` Grant Likely
2011-06-15 0:03 ` Randy Dunlap [this message]
2011-06-15 0:05 ` [PATCH 1/2] " Randy Dunlap
2011-06-16 14:37 ` Grant Likely
2011-06-15 0:06 ` [PATCH 2/2] gpio: include linux/gpio.h where needed Randy Dunlap
2011-06-15 0:34 ` Stephen Rothwell
2011-06-15 17:59 ` Randy Dunlap
2011-06-15 19:21 ` Grant Likely
2011-06-16 14:37 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110614170321.10e1caa7.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=laforge@gnufiish$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mad_soft@inbox$(echo .)ru \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox