Subject: Re: linux-next: Tree for July 21 (drivers/md/dm-raid)

From: NeilBrown <[email-masked]>
Date: Fri, 22 Jul 2011 08:10:40 +1000

On Thu, 21 Jul 2011 14:56:48 -0700 Randy Dunlap <[email-masked]> wrote:

> On Thu, 21 Jul 2011 16:55:42 +1000 Stephen Rothwell wrote:
> 
> > Hi all,
> 
> When CONFIG_DM_RAID=m and CONFIG_MD_RAID1 is not enabled:
> 
> ERROR: "md_raid1_congested" [drivers/md/dm-raid.ko] undefined!
> 
> due to:
> 
> 	if (rs->raid_type->level == 1)
> 		return md_raid1_congested(&rs->md, bits);
> 
> Should that just be surrounded with this?
> 
> #if defined(CONFIG_MD_RAID1) || defined(CONFIG_MD_RAID1_MODULE)
> ...
> #endif
> 
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***

I suspect the right thing to do is add
   select MD_RAID1
to the 
   config DM_RAID

stanza.  What do you think Jon?

NeilBrown