Subject: Re: [PATCH -next] tpm_tis: fix build when ACPI is not enabled

From: Ingo Molnar <[email-masked]>
Date: Wed, 3 Aug 2011 20:56:34 +0200

* Randy Dunlap <[email-masked]> wrote:

> From: Randy Dunlap <[email-masked]>
> 
> Fix tpm_tis.c build when CONFIG_ACPI is not enabled by providing
> a stub function.  Fixes many build errors/warnings:
> 
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name'
> drivers/char/tpm/tpm_tis.c:89: error: request for member 'list' in something not a structure or union
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name'
> drivers/char/tpm/tpm_tis.c:89: error: request for member 'list' in something not a structure or union
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name'
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name'
> drivers/char/tpm/tpm_tis.c:89: error: request for member 'list' in something not a structure or union
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name'
> drivers/char/tpm/tpm_tis.c:89: error: request for member 'list' in something not a structure or union
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name'
> drivers/char/tpm/tpm_tis.c:90: error: dereferencing pointer to incomplete type
> 
> Signed-off-by: Randy Dunlap <[email-masked]>
> Cc: Leendert van Doorn <[email-masked]>
> ---
>  drivers/char/tpm/tpm_tis.c |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

FYI, this build breakage is now upstream as well and triggers easily.

This fix was sent 5+ days ago (with still no reply to it), a day 
after this fix the security tree pull request was sent with this 
known build breakage included, so the bug is still unfixed upstream 
and no fix is in the pipeline AFAICS. Got lost?

Thanks,

	Ingo