Subject: Re: linux-next: Tree for Aug 24 (dynamic_debug)

From: Jason Baron <[email-masked]>
Date: Wed, 24 Aug 2011 15:32:45 -0400

On Wed, Aug 24, 2011 at 10:25:51AM -0700, Randy Dunlap wrote:
> On Wed, 24 Aug 2011 16:04:04 +1000 Stephen Rothwell wrote:
> 
> > Hi all,
> 
> When CONFIG_NET is not enabled (I see this on i386 builds):
> 
> lib/built-in.o: In function `__dynamic_netdev_dbg':
> (.text+0x9fda): undefined reference to `__netdev_printk'
> 
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***

Ok, we probably want something, like below, although something keeps
selecting CONFIG_NET, when I try to unset it, in my .config...so not yet
tested, but should work.

Thanks,

-Jason

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index ee3b9ba..e4760de 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -504,6 +504,8 @@ int __dynamic_dev_dbg(struct _ddebug *descriptor,
 }
 EXPORT_SYMBOL(__dynamic_dev_dbg);
 
+#ifdef CONFIG_NET
+
 int __dynamic_netdev_dbg(struct _ddebug *descriptor,
 		      const struct net_device *dev, const char *fmt, ...)
 {
@@ -528,6 +530,8 @@ int __dynamic_netdev_dbg(struct _ddebug *descriptor,
 }
 EXPORT_SYMBOL(__dynamic_netdev_dbg);
 
+#endif
+
 static __initdata char ddebug_setup_string[1024];
 static __init int ddebug_setup_query(char *str)
 {