From: Randy Dunlap <rdunlap@xenotime•net>
To: Mimi Zohar <zohar@linux•vnet.ibm.com>
Cc: Arnaud Lacombe <lacombar@gmail•com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Mimi Zohar <zohar@us•ibm.com>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
linux-kbuild@vger•kernel.org
Subject: Re: linux-next: Tree for Aug 22 (evm)
Date: Fri, 26 Aug 2011 10:00:11 -0700 [thread overview]
Message-ID: <20110826100011.9213d872.rdunlap@xenotime.net> (raw)
In-Reply-To: <1314362342.3224.19.camel@localhost.localdomain>
On Fri, 26 Aug 2011 08:39:02 -0400 Mimi Zohar wrote:
> On Tue, 2011-08-23 at 22:10 -0400, Arnaud Lacombe wrote:
> > Hi,
> >
> > On Tue, Aug 23, 2011 at 7:40 PM, Randy Dunlap <rdunlap@xenotime•net> wrote:
> > > I think that you are going to need to do something like Arnaud suggested
> > > and use "depends on TCG_TPM=y" instead of just "depends on TCG_TPM",
> > > unless you can convince someone that this is a kconfig bug.
> > >
> > dammit... I guess there is...
> >
> > If you consider the following Kconfig:
> >
> > config MOD
> > bool
> > default y
> > option modules
> >
> > config EXPERIMENTAL
> > bool
> > default y
> >
> > menuconfig A
> > tristate "A"
> > depends on EXPERIMENTAL
> >
> > config B
> > bool "B"
> >
> > config B0
> > bool
> >
> > config C
> > tristate "C"
> > depends on B
> >
> > config C0
> > tristate
> >
> > config D
> > boolean "D"
> > depends on A && B
> > select C
> > select C0
> >
> > config E
> > tristate "E"
> >
> > config F
> > tristate "F"
> > select E
> >
> > B (KEYS) allows to set C (TRUSTED_KEYS). Also, B (KEYS) and A
> > (TCG_TPM) allows to set D (EVM), which will select (C). Now,
> > menuconfig highlight the problem very well. Proceeding as following
> > A=m, B=y, C=m, E=y, F=y, we ends up having:
> >
> > <M> A --->
> > [*] B
> > {M} C
> > [*] D
> > -*- E
> > <*> F
> >
> > which translate in the following config:
> >
> > CONFIG_MOD=y
> > CONFIG_EXPERIMENTAL=y
> > CONFIG_A=m
> > CONFIG_B=y
> > CONFIG_C=m
> > CONFIG_C0=m
> > CONFIG_D=y
> > CONFIG_E=y
> > CONFIG_F=y
> >
> > I would have expected CONFIG_C and CONFIG_C0 to be 'y', just as 'E'.
> > If you remove D's dependency on 'A', everything works as expected. So
> > it would seem direct dependency state influence the state of reverse
> > dependencies...
> >
> > Will have a look...
> >
> > - Arnaud
>
> Thanks for looking into this! Instead of changing 'TCG_TPM' to
> 'TCG_TPM=y', the dependency should be on 'TRUSTED_KEYS=y'. Then when
> I've refactored ENCRYPTED_KEYS, removing the ENCRYPTED_KEYS dependency
> on TRUSTED_KEYS, the EVM dependency would be '(TRUSTED_KEYS=y ||
> TRUSTED_KEYS=n)'. Do you want a temporary fix for now?
Yes, linux-next (randconfig) builds are still failing, so we need something
to prevent that.
thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2011-08-26 17:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 4:53 linux-next: Tree for Aug 22 Stephen Rothwell
2011-08-22 16:10 ` linux-next: Tree for Aug 22 (drivers/power/pda_power.c) Randy Dunlap
2011-08-22 18:13 ` [PATCH -next] staging: fix comedi build when COMEDI_PCI is not enabled Randy Dunlap
2011-08-23 18:58 ` Greg KH
2011-08-23 20:03 ` Randy Dunlap
2011-08-22 18:30 ` [PATCH -next] power_supply: fix sysfs format warning Randy Dunlap
2011-08-23 13:27 ` Anton Vorontsov
2011-08-22 19:53 ` linux-next: Tree for Aug 22 (evm) Randy Dunlap
2011-08-22 20:18 ` Arnaud Lacombe
2011-08-23 0:47 ` Arnaud Lacombe
2011-08-23 0:49 ` Randy Dunlap
2011-08-23 2:09 ` Mimi Zohar
2011-08-23 2:24 ` Arnaud Lacombe
2011-08-24 2:07 ` Mimi Zohar
2011-08-23 2:32 ` Arnaud Lacombe
2011-08-23 23:40 ` Randy Dunlap
2011-08-24 2:10 ` Arnaud Lacombe
2011-08-26 12:39 ` Mimi Zohar
2011-08-26 17:00 ` Randy Dunlap [this message]
2011-08-27 6:06 ` Arnaud Lacombe
2011-09-02 0:32 ` Arnaud Lacombe
2011-09-02 1:40 ` Mimi Zohar
2011-09-02 2:21 ` Arnaud Lacombe
2011-09-02 15:01 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110826100011.9213d872.rdunlap@xenotime.net \
--to=rdunlap@xenotime$(echo .)net \
--cc=lacombar@gmail$(echo .)com \
--cc=linux-kbuild@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=zohar@linux$(echo .)vnet.ibm.com \
--cc=zohar@us$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox