From: Heiko Carstens <heiko.carstens@de•ibm.com>
To: Paul Gortmaker <paul.gortmaker@windriver•com>
Cc: linux-next@vger•kernel.org,
Frank Blaschka <blaschka@linux•vnet.ibm.com>,
Jan Glauber <jang@linux•vnet.ibm.com>
Subject: Re: [PATCH -next] qdio: add missing export.h include
Date: Wed, 28 Sep 2011 08:34:25 +0200 [thread overview]
Message-ID: <20110928063425.GA2621@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <4E824F3A.6070302@windriver.com>
On Tue, Sep 27, 2011 at 06:33:30PM -0400, Paul Gortmaker wrote:
> On 11-09-22 03:21 AM, Heiko Carstens wrote:
> > Fix compile breakage caused by splitting module.h:
> >
> > drivers/s390/cio/qdio_setup.c:31:1:
> > warning: data definition has no type or storage class [enabled by default]
> > drivers/s390/cio/qdio_setup.c:31:1:
> > warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int]
>
> Now that I look at this, and the other patch, I'm not
> seeing how this is possible. Unless there is some
> convoluted CPP magic going on, I don't see any instances
> of EXPORT_SYMBOL in qdio_setup.c -- similarly I don't
> see any module_ or MODULE_ references in zfcp_qdio.c
>
> Am I missing something obvious here? The line numbers
> you quote dont match anything meaningful -- so I'm wondering
> if perhaps these changes are meant to be in advance of the
> s390 changes you've got queued in next -- which is fine, but
> it would be nice to have that called out.
Oh right, I should have mentioned this. Sorry!
he two patches fix compile breakages only in -next because of s390
related patches in the scsi and net git trees. Since it's not possible
to add the compile fixes (at least for the new export.h header file)
to the scsi or net trees I just sent these patches towards you...
Thanks,
Heiko
next prev parent reply other threads:[~2011-09-28 6:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 7:21 [PATCH -next] qdio: add missing export.h include Heiko Carstens
2011-09-27 22:17 ` Paul Gortmaker
2011-09-27 22:33 ` Paul Gortmaker
2011-09-28 4:54 ` Stephen Rothwell
2011-09-28 6:34 ` Heiko Carstens [this message]
2011-09-28 14:03 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110928063425.GA2621@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de$(echo .)ibm.com \
--cc=blaschka@linux$(echo .)vnet.ibm.com \
--cc=jang@linux$(echo .)vnet.ibm.com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=paul.gortmaker@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox