Subject: Re: [PATCH] olpc: olpc-xo1-sci.c is an input driver, depends on INPUT

From: Andres Salomon <[email-masked]>
Date: Thu, 29 Sep 2011 13:34:46 -0700

On Thu, 29 Sep 2011 13:17:29 -0700
Randy Dunlap <[email-masked]> wrote:

> From: Randy Dunlap <[email-masked]>
> 
> Fix build errors when CONFIG_INPUT is disabled (shortened list):
> 
> olpc-xo1-sci.c:(.text+0x1aee6): undefined reference to `input_event'
> olpc-xo1-sci.c:(.text+0x1b077): undefined reference to
> `input_unregister_device' olpc-xo1-sci.c:(.text+0x1b081): undefined
> reference to `input_free_device'
> arch/x86/built-in.o:olpc-xo1-sci.c:(.text+0x1b270): more undefined
> references to `input_event' follow
> olpc-xo1-sci.c:(.devinit.text+0x155): undefined reference to
> `input_allocate_device' olpc-xo1-sci.c:(.devinit.text+0x1a4):
> undefined reference to `input_register_device'
> 
> Signed-off-by: Randy Dunlap <[email-masked]>
> Cc: Andres Salomon <[email-masked]>
> ---
> Found in linux-next but also applies to mainline.
> 
>  arch/x86/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- next-2011-0929.orig/arch/x86/Kconfig
> +++ next-2011-0929/arch/x86/Kconfig
> @@ -2052,7 +2052,7 @@ config OLPC_XO1_RTC
>  
>  config OLPC_XO1_SCI
>  	bool "OLPC XO-1 SCI extras"
> -	depends on OLPC && OLPC_XO1_PM
> +	depends on OLPC && OLPC_XO1_PM && INPUT
>  	select POWER_SUPPLY
>  	select GPIO_CS5535
>  	select MFD_CORE

Thanks!

Hm.  This might actually need a 'select INPUT' though, since
OLPC_XO1_SCI is bool while INPUT is tristate.  Sigh, bool..