public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk•ukuu.org.uk>
To: Andrew Morton <akpm00@gmail•com>
Cc: Randy Dunlap <rdunlap@xenotime•net>,
	Stephen Rothwell <sfr@canb•auug.org.au>,
	linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
	Andrew Morton <akpm@linux-foundation•org>,
	Mathias Nyman <mathias.nyman@linux•intel.com>
Subject: Re: [PATCH -next] x86 mrst: fix build error when X86_MRST is not enabled
Date: Fri, 30 Sep 2011 10:07:04 +0100	[thread overview]
Message-ID: <20110930100704.6ea882c8@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20110929161040.41f23573.akpm00@gmail.com>

> > This breaks Medfield so NAK
> > 
> > The correct behaviour should be 
> > 
> > INTEL_MID defined -> mrst_cpu_chip has meaning
> > INTEL_MID not defined -> mrst_identify_chip is 0
> > 
> > your change makes it 0 for Medfield which means it will crash on boot.
> 
> Randy's patch is an attempt to fix Mathias's "x86: rtc: don't register
> a platform RTC device for Intel MID platforms".

NAK this.

> I'm tempted to do a mass droppage, but then some of the patches might
> get forever lost.

Randy's patch breaks Medfield, simply because he's seeing an incomplete
set of merges. The stuff the x86 maintainers were sent already deals with
this. It's all simply a case of waiting for the trees to get back into
sync, at which point platform/x86/mrst will get built for INTEL_MID
general case.

> Could we please get some x86 maintainers on deck??

Well currently x86@kernel•org is undeliverable so that won't help you.

Alan

  reply	other threads:[~2011-09-30  9:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-29  6:57 linux-next: Tree for Sept 29 Stephen Rothwell
2011-09-29 19:50 ` linux-next: Tree for Sept 29 (kvm) Randy Dunlap
2011-09-29 22:58   ` Stephen Rothwell
2011-09-30 11:50     ` [PATCH] KVM: x86: Use do_div for tsc deadline calculation Jan Kiszka
2011-09-30 17:35       ` Randy Dunlap
2011-10-02  9:05       ` Avi Kivity
2011-09-29 20:17 ` [PATCH] olpc: olpc-xo1-sci.c is an input driver, depends on INPUT Randy Dunlap
2011-09-29 20:34   ` Andres Salomon
2011-09-29 20:36     ` Randy Dunlap
2011-10-06 17:12     ` Randy Dunlap
2011-09-29 20:35 ` [PATCH -next] x86 mrst: fix build error when X86_MRST is not enabled Randy Dunlap
2011-09-29 22:57   ` Alan Cox
2011-09-29 23:10     ` Andrew Morton
2011-09-30  9:07       ` Alan Cox [this message]
2011-09-29 23:16     ` Randy Dunlap
2011-09-30  9:04       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110930100704.6ea882c8@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk$(echo .)ukuu.org.uk \
    --cc=akpm00@gmail$(echo .)com \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=mathias.nyman@linux$(echo .)intel.com \
    --cc=rdunlap@xenotime$(echo .)net \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox