Subject: Re: [PATCH -next] usb gadget: fix langwell_udc.c build error

From: Felipe Balbi <[email-masked]>
Date: Mon, 10 Oct 2011 01:36:40 +0300

Hi,

On Sun, Oct 09, 2011 at 10:50:56AM -0700, Randy Dunlap wrote:
> On 10/08/11 03:03, Felipe Balbi wrote:
> > Hi,
> > 
> > On Fri, Oct 07, 2011 at 01:57:42PM -0700, Randy Dunlap wrote:
> >> From: Randy Dunlap <[email-masked]>
> >>
> >> Move function to fix langwell_udc.c build error:
> >>
> >> drivers/usb/gadget/langwell_udc.c: In function 'show_langwell_udc':
> >> drivers/usb/gadget/langwell_udc.c:1693:3: error: implicit declaration of function 'lpm_device_speed'
> >> drivers/usb/gadget/langwell_udc.c: At top level:
> >> drivers/usb/gadget/langwell_udc.c:2637:37: error: conflicting types for 'lpm_device_speed'
> >> drivers/usb/gadget/langwell_udc.c:1693:20: note: previous implicit declaration of 'lpm_device_speed' was here
> > 
> > I don't have this compile error on my branch, did something go in
> > without me noticing ?
> 
> probably not.  What version of gcc are you using?

I believe it did, I don't have lpm_device_speed() at all.

> I'm using 4.5.1.

4.6.1

> > Can you blame a comit which introduced this ?
> 
> I don't see such a commit.

$ git log --pretty=oneline -S'lpm_device_speed' HEAD --	\
	drivers/usb/gadget/langwell_udc.c

what's the output ?

> > btw, all I have is a warning.
> 
> What warning?

drivers/usb/gadget/langwell_udc.c: In function ‘langwell_ep_dequeue’:
drivers/usb/gadget/langwell_udc.c:919:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

-- 
balbi