Subject: Re: linux-next: build failure after merge of the md tree

From: NeilBrown <[email-masked]>
Date: Tue, 11 Oct 2011 16:42:27 +1100

On Tue, 11 Oct 2011 16:29:48 +1100 Stephen Rothwell <[email-masked]>
wrote:

> Hi Neil,
> 
> After merging the md tree, today's linux-next build (x86_64_allmodconfig)
> failed like this:
> 
> drivers/md/dm-raid.c:597:25: error: unknown type name 'mdk_rdev_t'
> drivers/md/dm-raid.c:614:24: error: unknown type name 'mddev_t'
> drivers/md/dm-raid.c:614:40: error: unknown type name 'mdk_rdev_t'
> drivers/md/dm-raid.c:654:23: error: unknown type name 'mdk_rdev_t'
> drivers/md/dm-raid.c:654:41: error: unknown type name 'mdk_rdev_t'
> drivers/md/dm-raid.c:692:34: error: unknown type name 'mddev_t'
> drivers/md/dm-raid.c:692:50: error: unknown type name 'mdk_rdev_t'
> drivers/md/dm-raid.c:812:27: error: unknown type name 'mddev_t'
> drivers/md/dm-raid.c:812:43: error: unknown type name 'mdk_rdev_t'
> drivers/md/dm-raid.c: In function 'analyse_superblocks':
> drivers/md/dm-raid.c:852:2: error: unknown type name 'mdk_rdev_t'
> drivers/md/dm-raid.c:853:2: error: unknown type name 'mddev_t'
> drivers/md/dm-raid.c:853:19: warning: initialization from incompatible pointer type [enabled by default]
> drivers/md/dm-raid.c:856:2: error: request for member 'same_set' in something not a structure or union
> drivers/md/dm-raid.c:856:2: error: request for member 'disks' in something not a structure or union
> drivers/md/dm-raid.c:856:2: error: request for member 'same_set' in something not a structure or union
> drivers/md/dm-raid.c:856:2: error: request for member 'same_set' in something not a structure or union
> drivers/md/dm-raid.c:856:2: error: request for member 'same_set' in something not a structure or union
> drivers/md/dm-raid.c:856:2: error: request for member 'same_set' in something not a structure or union
> drivers/md/dm-raid.c:856:2: warning: left-hand operand of comma expression has no effect [-Wunused-value]
> drivers/md/dm-raid.c:856:2: error: request for member 'same_set' in something not a structure or union
> drivers/md/dm-raid.c:856:2: error: request for member 'disks' in something not a structure or union
> drivers/md/dm-raid.c:856:2: error: request for member 'same_set' in something not a structure or union
> drivers/md/dm-raid.c:856:2: error: request for member 'same_set' in something not a structure or union
> drivers/md/dm-raid.c:856:2: error: request for member 'same_set' in something not a structure or union
> drivers/md/dm-raid.c:857:12: error: request for member 'meta_bdev' in something not a structure or union
> drivers/md/dm-raid.c:860:3: error: implicit declaration of function 'super_load' [-Werror=implicit-function-declaration]
> drivers/md/dm-raid.c:882:2: error: implicit declaration of function 'super_validate' [-Werror=implicit-function-declaration]
> drivers/md/dm-raid.c:885:2: error: request for member 'same_set' in something not a structure or union
> drivers/md/dm-raid.c:885:2: error: request for member 'disks' in something not a structure or union
> drivers/md/dm-raid.c:885:2: error: request for member 'same_set' in something not a structure or union
> drivers/md/dm-raid.c:885:2: error: request for member 'same_set' in something not a structure or union
> drivers/md/dm-raid.c:885:2: error: request for member 'same_set' in something not a structure or union
> drivers/md/dm-raid.c:885:2: error: request for member 'same_set' in something not a structure or union
> drivers/md/dm-raid.c:885:2: warning: left-hand operand of comma expression has no effect [-Wunused-value]
> drivers/md/dm-raid.c:885:2: error: request for member 'same_set' in something not a structure or union
> drivers/md/dm-raid.c:885:2: error: request for member 'disks' in something not a structure or union
> drivers/md/dm-raid.c:885:2: error: request for member 'same_set' in something not a structure or union
> drivers/md/dm-raid.c:885:2: error: request for member 'same_set' in something not a structure or union
> drivers/md/dm-raid.c:885:2: error: request for member 'same_set' in something not a structure or union
> drivers/md/dm-raid.c: In function 'raid_ctr':
> drivers/md/dm-raid.c:965:22: error: 'super_sync' undeclared (first use in this function)
> drivers/md/dm-raid.c:965:22: note: each undeclared identifier is reported only once for each function it appears in
> drivers/md/dm-raid.c: In function 'raid_status':
> drivers/md/dm-raid.c:1100:4: error: unknown type name 'raid5_conf_t'
> drivers/md/dm-raid.c:1103:4: error: request for member 'max_nr_stripes' in something not a structure or union
> drivers/md/dm-raid.c: In function 'raid_io_hints':
> drivers/md/dm-raid.c:1149:2: error: unknown type name 'raid5_conf_t'
> drivers/md/dm-raid.c:1152:46: error: request for member 'raid_disks' in something not a structure or union
> drivers/md/dm-raid.c:1152:65: error: request for member 'max_degraded' in something not a structure or union
> 
> Caused by commits 4251a3bcf0e1 ("md: removing typedefs:  mdk_rdev_t ->
> struct md_rdev") and 724d5bc7708a ("md: remove typedefs: mddev_t ->
> struct mddev").
> 
> Have you dropped better versions of these commits?  Please build test.

I'll add dm-raid back in to my build testing - I don't know why it dropped
out.

This will be fixed for tomorrow.
I might add the merge with the block layer too.

Thanks,
NeilBrown

> 
> I have used the version of the tree from next-20111006 since
> next-20111007 had another build problem.