From: "Rafael J. Wysocki" <rjw@sisk•pl>
To: "Srivatsa S. Bhat" <srivatsa.bhat@linux•vnet.ibm.com>
Cc: Fenghua Yu <fenghua.yu@intel•com>,
Linus Torvalds <torvalds@linux-foundation•org>,
Ingo Molnar <mingo@elte•hu>,
Andrew Morton <akpm@linux-foundation•org>,
Rusty Russell <rusty@rustcorp•com.au>,
linux-kernel <linux-kernel@vger•kernel.org>,
linux-pm <linux-pm@vger•kernel.org>,
linux-next <linux-next@vger•kernel.org>
Subject: Re: [PATCH v2] kernel/cpu.c: Add right qualifiers for alloc_frozen_cpus() and cpu_hotplug_pm_sync_init()
Date: Tue, 15 Nov 2011 21:17:14 +0100 [thread overview]
Message-ID: <201111152117.15026.rjw@sisk.pl> (raw)
In-Reply-To: <4EC200D4.9040505@linux.vnet.ibm.com>
On Tuesday, November 15, 2011, Srivatsa S. Bhat wrote:
> On 11/15/2011 05:27 AM, Fenghua Yu wrote:
> > From: Fenghua Yu <fenghua.yu@intel•com>
> >
> > Add __init for functions alloc_frozen_cpus() and cpu_hotplug_pm_sync_init()
> > because they are only called during boot time.
> >
> > Add static for function cpu_hotplug_pm_sync_init() because its scope is limited
> > in this file only.
> >
> > Signed-off-by: Fenghua Yu <fenghua.yu@intel•com>
>
> Acked-by: Srivatsa S. Bhat <srivatsa.bhat@linux•vnet.ibm.com>
Well, I guess I can take this one, right? Any objections from anyone?
Rafael
> > ---
> > v2: Change a function name typo in the title.
> >
> > kernel/cpu.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/kernel/cpu.c b/kernel/cpu.c
> > index 563f136..cf915b8 100644
> > --- a/kernel/cpu.c
> > +++ b/kernel/cpu.c
> > @@ -470,7 +470,7 @@ out:
> > cpu_maps_update_done();
> > }
> >
> > -static int alloc_frozen_cpus(void)
> > +static int __init alloc_frozen_cpus(void)
> > {
> > if (!alloc_cpumask_var(&frozen_cpus, GFP_KERNEL|__GFP_ZERO))
> > return -ENOMEM;
> > @@ -543,7 +543,7 @@ cpu_hotplug_pm_callback(struct notifier_block *nb,
> > }
> >
> >
> > -int cpu_hotplug_pm_sync_init(void)
> > +static int __init cpu_hotplug_pm_sync_init(void)
> > {
> > pm_notifier(cpu_hotplug_pm_callback, 0);
> > return 0;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
prev parent reply other threads:[~2011-11-15 20:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 23:57 [PATCH v2] kernel/cpu.c: Add right qualifiers for alloc_frozen_cpus() and cpu_hotplug_pm_sync_init() Fenghua Yu
2011-11-15 6:04 ` Srivatsa S. Bhat
2011-11-15 20:17 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111152117.15026.rjw@sisk.pl \
--to=rjw@sisk$(echo .)pl \
--cc=akpm@linux-foundation$(echo .)org \
--cc=fenghua.yu@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=rusty@rustcorp$(echo .)com.au \
--cc=srivatsa.bhat@linux$(echo .)vnet.ibm.com \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox