Subject: Re: linux-next: build failure after merge of the final tree (uprobes tree related)

From: Srikar Dronamraju <[email-masked]>
Date: Wed, 23 Nov 2011 15:24:43 +0530

Hey Stephen, 

> After merging the uprobes tree, today's linux-next build (sparc64
> defconfig) failed like this:
> 
> In file included from include/linux/mm_types.h:15:0,
>                  from include/linux/kmemcheck.h:4,
>                  from include/linux/skbuff.h:18,
>                  from net/8021q/vlan_core.c:1:
> include/linux/uprobes.h: In function 'register_uprobe':
> include/linux/uprobes.h:148:10: error: 'ENOSYS' undeclared (first use in this function)
> 

Oh sorry for missing this.

> And several more.
> 
> Caused by commit fb16338b69cd ("register_unregister_uprobe" - "Uprobes:
> register/unregister probes").
> 
> I have added this patch for today:
> 
> From: Stephen Rothwell <[email-masked]>
> Date: Wed, 23 Nov 2011 15:11:20 +1100
> Subject: [PATCH] uprobes: using ENOSYS requires errno.h
> 
> Fixes this build problem:
> 
> In file included from include/linux/mm_types.h:15:0,
>                  from include/linux/kmemcheck.h:4,
>                  from include/linux/skbuff.h:18,
>                  from net/8021q/vlan_core.c:1:
> include/linux/uprobes.h: In function 'register_uprobe':
> include/linux/uprobes.h:148:10: error: 'ENOSYS' undeclared (first use in this function)
> 
> when CONFIG_UPROBES is not defined.
> 
> Signed-off-by: Stephen Rothwell <[email-masked]>
> ---
>  include/linux/uprobes.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h
> index 091dfb8..e2e0674 100644
> --- a/include/linux/uprobes.h
> +++ b/include/linux/uprobes.h
> @@ -23,6 +23,7 @@
>   *	Jim Keniston
>   */
>  
> +#include <linux/errno.h>
>  #include <linux/rbtree.h>
>  
>  struct vm_area_struct;

Yes, this is the right fix. So I will fold this into my patch.

-- 
Thanks and Regards
Srikar