From: David Miller <davem@davemloft•net>
To: plagnioj@jcrosoft•com
Cc: nicolas.ferre@atmel•com, jamie@jamieiles•com,
netdev@vger•kernel.org, sfr@canb•auug.org.au,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH] at91_ether: use gpio_is_valid for phy IRQ line
Date: Wed, 30 Nov 2011 00:40:44 -0500 (EST) [thread overview]
Message-ID: <20111130.004044.1357362466737795134.davem@davemloft.net> (raw)
In-Reply-To: <20111130044403.GY15008@game.jcrosoft.org>
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft•com>
Date: Wed, 30 Nov 2011 05:44:03 +0100
> On 18:53 Tue 29 Nov , David Miller wrote:
>> From: Nicolas Ferre <nicolas.ferre@atmel•com>
>> Date: Thu, 24 Nov 2011 22:21:14 +0100
>>
>> > Use the generic gpiolib gpio_is_valid() function to test
>> > if the phy IRQ line GPIO is actually provided.
>> >
>> > For non-connected or non-existing phy IRQ lines, -EINVAL
>> > value is used for phy_irq_pin field of struct at91_eth_data.
>> >
>> > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel•com>
>>
>> I'm assuming this goes through the ARM tree, because in both of my networking
>> trees there is no ARM at91 implementation of gpio_is_valid().
> yes the depending patch series is in the arm-soc
>
> can we have your ack or sob?
Acked-by: David S. Miller <davem@davemloft•net>
prev parent reply other threads:[~2011-11-30 5:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1322128098-17724-1-git-send-email-jamie@jamieiles.com>
2011-11-24 21:21 ` [PATCH] at91_ether: use gpio_is_valid for phy IRQ line Nicolas Ferre
2011-11-24 22:28 ` Jamie Iles
2011-11-25 13:47 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-25 13:56 ` Nicolas Ferre
2011-11-29 23:53 ` David Miller
2011-11-30 4:44 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-30 5:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111130.004044.1357362466737795134.davem@davemloft.net \
--to=davem@davemloft$(echo .)net \
--cc=jamie@jamieiles$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.ferre@atmel$(echo .)com \
--cc=plagnioj@jcrosoft$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox