Subject: Re: linux-next: build failure after merge of the final tree (akpm tree related)

From: NeilBrown <[email-masked]>
Date: Sat, 17 Dec 2011 16:02:28 +1100

On Sat, 17 Dec 2011 15:42:19 +1100 Stephen Rothwell <[email-masked]>
wrote:

> Hi all,
> 
> After merging the final tree, today's linux-next build (m68k allmodconfig)
> failed like this:
> 
> drivers/leds/leds-tca6507.c:158: error: field 'gpio' has incomplete type
> drivers/leds/leds-tca6507.c: In function 'tca6507_gpio_set_value':
> drivers/leds/leds-tca6507.c:534: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/leds/leds-tca6507.c:534: warning: initialization from incompatible pointer type
> drivers/leds/leds-tca6507.c: In function 'tca6507_probe':
> drivers/leds/leds-tca6507.c:618: error: implicit declaration of function 'gpiochip_add'
> drivers/leds/leds-tca6507.c: In function 'tca6507_remove':
> drivers/leds/leds-tca6507.c:651: error: implicit declaration of function 'gpiochip_remove'
> 
> Caused by commit 7a9244d89523 ("leds: add driver for TCA6507 LED controller").
> 
> Maybe this driver needs some dependencies ...

Yes... I think it actually needs the 'gpio' aspect of the driver to be
dependant of GPIOLIB being available.

I'll get a patch or two off to Andrew on Monday.

Thanks,
NeilBrown