From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>
To: kvalo-A+ZNKFmMK5xy9aJCnZT0Uw@public•gmane.org
Cc: linville-2XuSBdqkA4R54TAoqtyWWQ@public•gmane.org,
ath6kl-devel-zC7DfRvBq/JWk0Htik3J/w@public•gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
sfr-3FnU+UHB4dNDw9hX6IcOSA@public•gmane.org,
linux-next-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [PATCH] ath6kl: force building as a module
Date: Wed, 04 Jan 2012 13:28:55 -0500 (EST) [thread overview]
Message-ID: <20120104.132855.1261837733994182914.davem@davemloft.net> (raw)
In-Reply-To: <4F042078.5040902-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org>
From: Kalle Valo <kvalo-A+ZNKFmMK5xy9aJCnZT0Uw@public•gmane.org>
Date: Wed, 4 Jan 2012 11:48:40 +0200
> On 01/04/2012 11:41 AM, Kalle Valo wrote:
>> Stephen reported that ath6kl fails if both sdio and usb are built
>> into the kernel:
>>
>> ath6kl/cfg80211.c:27:1: error: expected ')' before 'KBUILD_MODNAME'
>> ath6kl/cfg80211.c:27:1: error: 'KBUILD_MODNAME' undeclared here (not in a function)
>> ath6kl/cfg80211.c:27:1: error: expected ',' or ';' before string constant
>>
>> As a temporary fix make ath6kl build only as a module. This will be reverted
>> once a separate ath6kl core module is implemented which will fix this
>> properly.
>>
>> Reported-by: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public•gmane.org>
>> Signed-off-by: Kalle Valo <kvalo-A+ZNKFmMK5xy9aJCnZT0Uw@public•gmane.org>
>
> Sorry, forgot to CC people. The original patch is here:
>
> http://marc.info/?l=linux-wireless&m=132567025132302&w=2
>
> John, can you please take this directly so that the build problem gets
> fixed quickly? I will also apply it to ath6kl.git but that should not
> create any merge problems.
John can you very much NOT include this change, and if the ath6kl maintainers
can't fix this properly then revert the changes that caused this regression
in the first place?
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-01-04 18:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120104094134.28754.39652.stgit@x201>
2012-01-04 9:48 ` [PATCH] ath6kl: force building as a module Kalle Valo
[not found] ` <4F042078.5040902-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org>
2012-01-04 18:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104.132855.1261837733994182914.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public$(echo .)gmane.org \
--cc=ath6kl-devel-zC7DfRvBq/JWk0Htik3J/w@public$(echo .)gmane.org \
--cc=kvalo-A+ZNKFmMK5xy9aJCnZT0Uw@public$(echo .)gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public$(echo .)gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox