Subject: Re: linux-next: build failure after merge of the battery tree

From: Anton Vorontsov <[email-masked]>
Date: Mon, 9 Jan 2012 17:10:37 +0400

On Mon, Jan 09, 2012 at 01:59:29PM +0530, Ashish Jangam wrote:
> > Hi Anton,
> > 
> > After merging the battery tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > drivers/power/da9052-battery.c: In function 'da9052_bat_read_volt':
> > drivers/power/da9052-battery.c:293:2: error: implicit declaration of function 'da9052_adc_manual_read' [-Werror=implicit-function-declaration]
> > drivers/power/da9052-battery.c: In function 'da9052_bat_check_presence':
> > drivers/power/da9052-battery.c:306:2: error: implicit declaration of function 'da9052_adc_read_temp' [-Werror=implicit-function-declaration]
> > drivers/power/da9052-battery.c: In function 'da9052_determine_vc_tbl_index':
> > drivers/power/da9052-battery.c:348:1: warning: control reaches end of non-void function [-Wreturn-type]
> > cc1: some warnings being treated as errors
> > 
> > Caused by commit ded7fc7b0550 ("power_supply: Add DA9052 battery driver").
> > 
> > The commit message says "This driver depends on DA9052 MFD core dirver for definitions and methods".  That core is presumably still pending inclusion.

Well, it is in the MFD tree already, otherwise allmodconfig would not
be able to select this driver.

> > I have used the battery tree from next-20120104 for today.
> This patch depends upon Da9052/53 MFD core and also on one of its incremental patch for ADC that got these functions definitions. Below is that patch.
> We had already posted this patch.
> 
> Signed-off-by: David Dajun Chen <[email-masked]>
> Signed-off-by: Ashish Jangam <[email-masked]>
> ---

So, this patch should go via MFD tree asap. Otherwise, I'll have to
disable this driver by making it depend on 'broken' in Kconfig.

Thanks,

-- 
Anton Vorontsov
Email: [email-masked]