From: "Heiko Stübner" <heiko@sntech•de>
To: Paul Gortmaker <paul.gortmaker@windriver•com>
Cc: Mark Brown <broonie@opensource•wolfsonmicro.com>,
kgene.kim@samsung•com, ben-linux@fluff•org, tiwai@suse•de,
linux-next@vger•kernel.org
Subject: Re: linux-next broken by "ARM: S3C2440: move mach-s3c2440/* into mach-s3c24xx/"
Date: Thu, 8 Mar 2012 21:44:53 +0100 [thread overview]
Message-ID: <201203082144.54156.heiko@sntech.de> (raw)
In-Reply-To: <4F590F74.2030007@windriver.com>
Am Donnerstag 08 März 2012, 20:58:44 schrieb Paul Gortmaker:
> On 12-03-08 02:12 PM, Mark Brown wrote:
> > On Thu, Mar 08, 2012 at 11:23:26AM -0500, Paul Gortmaker wrote:
> >> Something bad happened in this commit (dd6f01b5cc). It looks like
> >> the moved file is truncated, causing this failure:
> >>
> >> http://kisskb.ellerman.id.au/kisskb/buildresult/5818815/
> >>
> >> I believe it came in via the fix/asoc tree.
> >
> > Hrm? What is "it" in this context, and what was your analysis here?
> > Nothing in the page you're linking to above suggests something audio
> > related...
>
> The "it" was the commit in the subject, and the ID in the above text.
> That was the last commit to have touched this file (via moving it).
>
> What I took as a relation to fix/asoc was shown in the text you've
> gone and deleted here in the follow up.
>
> In any case, it does appear the file was broken before it was moved.
> The offending commit is actually c1ba544f81544ed9613ad5d058968533dbcef4b2
>
> "ARM: S3C24XX: Fix restart on S3C2442"
>
> It appears that a closing brace was dropped when it was integrated.
kgene wrote in "[PATCH] ARM: S3C2440: Fixed build error for s3c244x":
> This happened when I applied Heiko's 'Fix restart on S3C2442'.
> It was my fault :( and this should be sent before release v3.3.
and was applied by Olof today.
Heiko
next prev parent reply other threads:[~2012-03-08 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 16:23 linux-next broken by "ARM: S3C2440: move mach-s3c2440/* into mach-s3c24xx/" Paul Gortmaker
2012-03-08 19:12 ` Mark Brown
2012-03-08 19:58 ` Paul Gortmaker
2012-03-08 20:44 ` Heiko Stübner [this message]
2012-03-09 12:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203082144.54156.heiko@sntech.de \
--to=heiko@sntech$(echo .)de \
--cc=ben-linux@fluff$(echo .)org \
--cc=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=kgene.kim@samsung$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=tiwai@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox