From: Mark Brown <broonie@opensource•wolfsonmicro.com>
To: Paul Gortmaker <paul.gortmaker@windriver•com>
Cc: Haojian Zhuang <haojian.zhuang@gmail•com>,
lost.distance@yahoo•com, linux-arm-kernel@lists•infradead.org,
linux-next@vger•kernel.org
Subject: Re: [PATCH] ARM: pxa: fix regulator related build fail in magician_defconfig
Date: Wed, 14 Mar 2012 12:32:36 +0000 [thread overview]
Message-ID: <20120314123236.GE3133@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F608F4F.8020106@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
On Wed, Mar 14, 2012 at 08:30:07AM -0400, Paul Gortmaker wrote:
> On 12-03-14 04:38 AM, Haojian Zhuang wrote:
> > How do you think about Mark's comments? Use dev_name() at here.
> I'm not sure I quite understand you. I'd looked up the
> structs and got their respective value that would be
> returned by dev_name(), which is what I thought was
> requested of me.
Yes, that's what you should do. Calling dev_name() is only possible if
you have the struct device and removing the need for the struct device
is exactly what we're trying to avoid here.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-14 12:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 19:46 [PATCH] ARM: pxa: fix regulator related build fail in magician_defconfig Paul Gortmaker
2012-03-06 20:01 ` Mark Brown
2012-03-06 20:49 ` [PATCH v2] " Paul Gortmaker
2012-03-07 1:46 ` Paul Parsons
2012-03-07 14:46 ` Paul Gortmaker
2012-03-07 14:57 ` Mark Brown
2012-03-08 21:34 ` [PATCH] " Paul Gortmaker
2012-03-09 2:47 ` Paul Parsons
2012-03-14 8:38 ` Haojian Zhuang
2012-03-14 12:30 ` Paul Gortmaker
2012-03-14 12:32 ` Mark Brown [this message]
2012-03-28 9:43 ` Russell King - ARM Linux
2012-03-28 10:18 ` Mark Brown
2012-03-28 13:36 ` Haojian Zhuang
2012-03-28 17:56 ` Russell King - ARM Linux
2012-03-28 18:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120314123236.GE3133@opensource.wolfsonmicro.com \
--to=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=haojian.zhuang@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=lost.distance@yahoo$(echo .)com \
--cc=paul.gortmaker@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox